Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Having multiple HTTPRoute controllers causes Linkerd to constantly emit HTTPRoute Patches #13327

Closed
DerekTBrown opened this issue Nov 14, 2024 · 1 comment
Labels

Comments

@DerekTBrown
Copy link
Contributor

What is the issue?

  • The policy-controller performs periodic reconciliation of HTTPRoute statuses.
  • This logic is supposed to only perform a PATCH when the desired .status.parents != the actual .status.parents.
  • The logic used to compare the desired and actual state is order-dependent. Thus if statuses from other controllers aren't in the order Linkerd expects, it will PATCH the HTTPRoute.
  • This isn't the desired behavior, since the order of elements elements in .status.parents doesn't matter.

How can it be reproduced?

  • I have a unit test in the attached PR that reproduces this issue.

Logs, error output, etc

N/A

output of linkerd check -o short

N/A

Environment

Kubernetes: 1.28
Linkerd: Master

Possible solution

No response

Additional context

No response

Would you like to work on fixing this bug?

yes

@DerekTBrown
Copy link
Contributor Author

Fix/Repro: #13328

@olix0r olix0r closed this as completed in f8a1343 Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant