Support intra-broker throttling (replica.alter.log.dirs.io.max.bytes.per.second) #2145
Conversation
|
This PR is an WIP; I will test this feature in our in-house fork (@naver) this week. Stay tuned!! 🙃 |
|
@aswinayyolath @mhratson @jiao-zhangS Could you kindly have a look? We adopted this patch to our in-house distribution and confirmed it works correctly. 🙏 |
…ationThrottledRate
- Add: setLogDirThrottles, setLogDirThrottledRateIfNecessary - Rename: removeReplicationThrottledRateFromBroker → removeThrottledRatesFromBroker
…oker rebalanacing
- Rename: ReplicationThrottleHelper.clearThrottles → clearInterBrokerThrottles
- Add ReplicationThrottleHelper.clearIntraBrokerThrottles
- Executor.intraBrokerMoveReplicas now calls ReplicationThrottleHelper.setLogDirThrottles, ReplicationThrottleHelper.clearIntraBrokerThrottles
dongjinleekr
force-pushed
the
feature/1851
branch
from
4781c13 to
c59c864
Compare
| @@ -1707,6 +1729,11 @@ private void intraBrokerMoveReplicas() { | |||
| waitForIntraBrokerReplicaTasksToFinish(); | |||
| inExecutionTasks = inExecutionTasks(); | |||
| } | |||
|
|
|||
| if (_logDirThrottle != null) { | |||
There was a problem hiding this comment.
for my understanding, why the underscore in the variable names here?
There was a problem hiding this comment.
In consistency with _replicationThrottle.
I don't see any issues with this PR, but I'm not a maintainer of this project. We need a maintainer to review this and add their approval. |
|
@CCisGG could you please review this PR? |
|
@CCisGG Hello. Could you please have a look when you are free? 🙏 |
|
Hi @mhratson, would you mind taking a look at this one? Thanks! |
This PR resolves #1851.