forked from argoproj/argo-cd
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test UI, fix bugs #1
Open
crenshaw-dev
wants to merge
20
commits into
linghaoSu:fix/sidecar-state
Choose a base branch
from
crenshaw-dev:fix/sidecar-state-ui
base: fix/sidecar-state
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
test UI, fix bugs #1
crenshaw-dev
wants to merge
20
commits into
linghaoSu:fix/sidecar-state
from
crenshaw-dev:fix/sidecar-state-ui
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: check err before use schedule and duration Signed-off-by: daengdaengLee <[email protected]> * test: add tests for invalid schedule and duration Signed-off-by: daengdaengLee <[email protected]> * feat: change to return error when sync window is invalid Signed-off-by: daengdaengLee <[email protected]> * fix: use assert.Error or assert.NoError Signed-off-by: daengdaengLee <[email protected]> * fix: use require instead of assert Signed-off-by: daengdaengLee <[email protected]> --------- Signed-off-by: daengdaengLee <[email protected]>
Signed-off-by: CI <[email protected]> Co-authored-by: CI <[email protected]>
argoproj#20363) Bumps [github.com/bmatcuk/doublestar/v4](https://github.com/bmatcuk/doublestar) from 4.6.1 to 4.7.1. - [Release notes](https://github.com/bmatcuk/doublestar/releases) - [Commits](bmatcuk/doublestar@v4.6.1...v4.7.1) --- updated-dependencies: - dependency-name: github.com/bmatcuk/doublestar/v4 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: simplify 'get repo' API implementation Signed-off-by: Michael Crenshaw <[email protected]> * import order Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]>
…) (argoproj#20337) * docs: feature maturity page for alpha and beta features (argoproj#20336) Signed-off-by: Michael Crenshaw <[email protected]> * typos Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
…rgoproj#20378) Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.111.0 to 0.112.0. - [Release notes](https://github.com/xanzy/go-gitlab/releases) - [Changelog](https://github.com/xanzy/go-gitlab/blob/main/releases_test.go) - [Commits](xanzy/go-gitlab@v0.111.0...v0.112.0) --- updated-dependencies: - dependency-name: github.com/xanzy/go-gitlab dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rgoproj#20377) Bumps [github.com/redis/go-redis/v9](https://github.com/redis/go-redis) from 9.6.1 to 9.6.2. - [Release notes](https://github.com/redis/go-redis/releases) - [Changelog](https://github.com/redis/go-redis/blob/master/CHANGELOG.md) - [Commits](redis/go-redis@v9.6.1...v9.6.2) --- updated-dependencies: - dependency-name: github.com/redis/go-redis/v9 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…s only secrets related to appset (argoproj#20309)
…golang.org/grpc/otelgrpc (argoproj#20376) Bumps [go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc](https://github.com/open-telemetry/opentelemetry-go-contrib) from 0.55.0 to 0.56.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.55.0...zpages/v0.56.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: proxy support Signed-off-by: pashakostohrys <[email protected]> * feat: proxy support Signed-off-by: pashakostohrys <[email protected]> * feat: proxy support Signed-off-by: pashakostohrys <[email protected]> * fix linter Signed-off-by: pashakostohrys <[email protected]> * small improvements Signed-off-by: pashakostohrys <[email protected]> * add cluster test Signed-off-by: pashakostohrys <[email protected]> * fix linter Signed-off-by: pashakostohrys <[email protected]> * change error message Signed-off-by: pashakostohrys <[email protected]> * override always will change proxy url Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: pashakostohrys <[email protected]>
14 tasks
* fix(controller): change pod status calculate with sidecar Signed-off-by: linghaoSu <[email protected]> * fix(controller): add restartable sidecar count in total container display Signed-off-by: linghaoSu <[email protected]> * fix(controller): update info test case conditions Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Linghao Su <[email protected]> * fix(controller): add more test case to cover more conditions Signed-off-by: linghaoSu <[email protected]> * fix(ui): check is condition exist before for of Signed-off-by: linghaoSu <[email protected]> --------- Signed-off-by: linghaoSu <[email protected]> Signed-off-by: Linghao Su <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: linghaoSu <[email protected]>
…play Signed-off-by: linghaoSu <[email protected]>
crenshaw-dev
force-pushed
the
fix/sidecar-state-ui
branch
from
October 15, 2024 19:17
6cc0a88
to
e7cd18d
Compare
Signed-off-by: Michael Crenshaw <[email protected]> oops Signed-off-by: Michael Crenshaw <[email protected]> indent Signed-off-by: Michael Crenshaw <[email protected]> fix accidental duplication Signed-off-by: Michael Crenshaw <[email protected]>
crenshaw-dev
force-pushed
the
fix/sidecar-state-ui
branch
from
October 15, 2024 19:18
e7cd18d
to
016d5af
Compare
Signed-off-by: Michael Crenshaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recommend reviewing with this link to ignore whitespace: https://github.com/linghaoSu/argo-cd/pull/1/files?w=1