Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test UI, fix bugs #1

Open
wants to merge 20 commits into
base: fix/sidecar-state
Choose a base branch
from

Conversation

crenshaw-dev
Copy link

@crenshaw-dev crenshaw-dev commented Oct 15, 2024

  • group the go tests for tidiness and run in parallel
  • add tests for UI presentation of init status
  • fix bugs in UI presentation to match backend behavior

I recommend reviewing with this link to ignore whitespace: https://github.com/linghaoSu/argo-cd/pull/1/files?w=1

daengdaengLee and others added 15 commits October 12, 2024 13:32
* fix: check err before use schedule and duration

Signed-off-by: daengdaengLee <[email protected]>

* test: add tests for invalid schedule and duration

Signed-off-by: daengdaengLee <[email protected]>

* feat: change to return error when sync window is invalid

Signed-off-by: daengdaengLee <[email protected]>

* fix: use assert.Error or assert.NoError

Signed-off-by: daengdaengLee <[email protected]>

* fix: use require instead of assert

Signed-off-by: daengdaengLee <[email protected]>

---------

Signed-off-by: daengdaengLee <[email protected]>
argoproj#20363)

Bumps [github.com/bmatcuk/doublestar/v4](https://github.com/bmatcuk/doublestar) from 4.6.1 to 4.7.1.
- [Release notes](https://github.com/bmatcuk/doublestar/releases)
- [Commits](bmatcuk/doublestar@v4.6.1...v4.7.1)

---
updated-dependencies:
- dependency-name: github.com/bmatcuk/doublestar/v4
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: simplify 'get repo' API implementation

Signed-off-by: Michael Crenshaw <[email protected]>

* import order

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
…) (argoproj#20337)

* docs: feature maturity page for alpha and beta features (argoproj#20336)

Signed-off-by: Michael Crenshaw <[email protected]>

* typos

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
…rgoproj#20378)

Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.111.0 to 0.112.0.
- [Release notes](https://github.com/xanzy/go-gitlab/releases)
- [Changelog](https://github.com/xanzy/go-gitlab/blob/main/releases_test.go)
- [Commits](xanzy/go-gitlab@v0.111.0...v0.112.0)

---
updated-dependencies:
- dependency-name: github.com/xanzy/go-gitlab
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rgoproj#20377)

Bumps [github.com/redis/go-redis/v9](https://github.com/redis/go-redis) from 9.6.1 to 9.6.2.
- [Release notes](https://github.com/redis/go-redis/releases)
- [Changelog](https://github.com/redis/go-redis/blob/master/CHANGELOG.md)
- [Commits](redis/go-redis@v9.6.1...v9.6.2)

---
updated-dependencies:
- dependency-name: github.com/redis/go-redis/v9
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…golang.org/grpc/otelgrpc (argoproj#20376)

Bumps [go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc](https://github.com/open-telemetry/opentelemetry-go-contrib) from 0.55.0 to 0.56.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.55.0...zpages/v0.56.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: proxy support

Signed-off-by: pashakostohrys <[email protected]>

* feat: proxy support

Signed-off-by: pashakostohrys <[email protected]>

* feat: proxy support

Signed-off-by: pashakostohrys <[email protected]>

* fix linter

Signed-off-by: pashakostohrys <[email protected]>

* small improvements

Signed-off-by: pashakostohrys <[email protected]>

* add cluster test

Signed-off-by: pashakostohrys <[email protected]>

* fix linter

Signed-off-by: pashakostohrys <[email protected]>

* change error message

Signed-off-by: pashakostohrys <[email protected]>

* override always will change proxy url

Signed-off-by: pashakostohrys <[email protected]>

---------

Signed-off-by: pashakostohrys <[email protected]>
linghaoSu and others added 3 commits October 15, 2024 15:05
* fix(controller): change pod status calculate with sidecar

Signed-off-by: linghaoSu <[email protected]>

* fix(controller): add restartable sidecar count in total container display

Signed-off-by: linghaoSu <[email protected]>

* fix(controller): update info test case conditions

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Linghao Su <[email protected]>

* fix(controller): add more test case to cover more conditions

Signed-off-by: linghaoSu <[email protected]>

* fix(ui): check is condition exist before for of

Signed-off-by: linghaoSu <[email protected]>

---------

Signed-off-by: linghaoSu <[email protected]>
Signed-off-by: Linghao Su <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>

oops

Signed-off-by: Michael Crenshaw <[email protected]>

indent

Signed-off-by: Michael Crenshaw <[email protected]>

fix accidental duplication

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants