Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manage clusters via proxy #20374

Merged
merged 9 commits into from
Oct 15, 2024

Conversation

pasha-codefresh
Copy link
Member

@pasha-codefresh pasha-codefresh commented Oct 14, 2024

May fix
#8314
#6043

Forked from: #9496

Huge thanks and credit to initial contributor @ls0f

Signed-off-by: pashakostohrys <[email protected]>
@pasha-codefresh pasha-codefresh requested review from a team as code owners October 14, 2024 16:56
Copy link

bunnyshell bot commented Oct 14, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 28.00000% with 18 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@7ab5015). Learn more about missing BASE report.
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apis/application/v1alpha1/types.go 43.75% 6 Missing and 3 partials ⚠️
cmd/argocd/commands/cluster.go 0.00% 6 Missing ⚠️
cmd/util/cluster.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #20374   +/-   ##
=========================================
  Coverage          ?   55.98%           
=========================================
  Files             ?      322           
  Lines             ?    44772           
  Branches          ?        0           
=========================================
  Hits              ?    25067           
  Misses            ?    17105           
  Partials          ?     2600           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: pashakostohrys <[email protected]>
Signed-off-by: pashakostohrys <[email protected]>
Signed-off-by: pashakostohrys <[email protected]>
Signed-off-by: pashakostohrys <[email protected]>
@ls0f
Copy link
Contributor

ls0f commented Oct 15, 2024

nice work 👍

Signed-off-by: pashakostohrys <[email protected]>
Signed-off-by: pashakostohrys <[email protected]>
Signed-off-by: pashakostohrys <[email protected]>
@alexmt alexmt merged commit d16df52 into argoproj:master Oct 15, 2024
27 checks passed
@todaywasawesome
Copy link
Contributor

Thanks @reggie-k for the in-depth review!

@qixiaobo
Copy link

May fix #8314 #6043

Forked from: #9496

Huge thanks and credit to initial contributor @ls0f

Great, long time waiting for the feature

austin5219 pushed a commit to austin5219/argo-cd that referenced this pull request Oct 16, 2024
* feat: proxy support

Signed-off-by: pashakostohrys <[email protected]>

* feat: proxy support

Signed-off-by: pashakostohrys <[email protected]>

* feat: proxy support

Signed-off-by: pashakostohrys <[email protected]>

* fix linter

Signed-off-by: pashakostohrys <[email protected]>

* small improvements

Signed-off-by: pashakostohrys <[email protected]>

* add cluster test

Signed-off-by: pashakostohrys <[email protected]>

* fix linter

Signed-off-by: pashakostohrys <[email protected]>

* change error message

Signed-off-by: pashakostohrys <[email protected]>

* override always will change proxy url

Signed-off-by: pashakostohrys <[email protected]>

---------

Signed-off-by: pashakostohrys <[email protected]>
Signed-off-by: austin5219 <[email protected]>
@dodistyo
Copy link

on what version this feature is available? I can see that it's already on master branch

@pasha-codefresh
Copy link
Member Author

@dodistyo , it will be part of 2.14

@dodistyo
Copy link

dodistyo commented Oct 24, 2024

currently, the feature should be available in the image tag latest, right? @pasha-codefresh

Update:
I have tried it using latest image. adding cluster with the cli using --proxy-url argument works perfectly.
But the cluster addition using secret is not working, got failed status and timeout. or sometimes stuck at unknown status.

@pasha-codefresh
Copy link
Member Author

Yeah @dodistyo i it should work under latest tag. I will take a look why it may happens

adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
* feat: proxy support

Signed-off-by: pashakostohrys <[email protected]>

* feat: proxy support

Signed-off-by: pashakostohrys <[email protected]>

* feat: proxy support

Signed-off-by: pashakostohrys <[email protected]>

* fix linter

Signed-off-by: pashakostohrys <[email protected]>

* small improvements

Signed-off-by: pashakostohrys <[email protected]>

* add cluster test

Signed-off-by: pashakostohrys <[email protected]>

* fix linter

Signed-off-by: pashakostohrys <[email protected]>

* change error message

Signed-off-by: pashakostohrys <[email protected]>

* override always will change proxy url

Signed-off-by: pashakostohrys <[email protected]>

---------

Signed-off-by: pashakostohrys <[email protected]>
Signed-off-by: Adrian Aneci <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants