Migrate examples to winit's new "app" API #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
approved these changes
Jul 15, 2024
examples/simple/src/main.rs
Outdated
|
|
||
| // The vello RenderContext which is a global context that lasts for the lifetime of the application | ||
| let mut render_cx = RenderContext::new(); | ||
| struct RenderStateWithContext<'s> { |
There was a problem hiding this comment.
I think we should rename this to something which describes what it is for, rather than what it contains. E.g. SimpleVelloApp?
There was a problem hiding this comment.
Thanks for the suggestion! SimpleVelloApp sounds better.
Thanks, I think I can address it in this pull request. |
|
Sorry, I tried Here's the migrated code of |
|
Hmm. I'll land this then. Would you mind making a draft follow-up PR with those changes? |
|
Sure, I will! |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 17, 2024
Second round of #626 Currently, this crashes with the following on my local, so I think I'm doing something wrong. ``` Running `target\debug\with_winit_bin.exe` [2024-07-15T15:33:30.317Z ERROR wgpu_hal::vulkan::instance] GENERAL [Loader Message (0x0)] loader_scanned_icd_add: Driver C:\Windows\System32\DriverStore\FileRepository\u0379858.inf_amd64_1719b9caae095668\B377432\.\amdvlk64.dll says it supports interface version 6 but still exports core entrypoints (Policy #LDP_DRIVER_6) [2024-07-15T15:33:30.318Z ERROR wgpu_hal::vulkan::instance] objects: (type: INSTANCE, hndl: 0x1ca928fbea0, name: ?) Initialising in parallel using 14 threads Parsed svg Ghostscript_Tiger in 8.3298ms Encoded svg Ghostscript_Tiger in 893.9µs thread 'main' panicked at examples\with_winit\src\lib.rs:511:22: failed to get surface texture: Timeout note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace error: process didn't exit successfully: `target\debug\with_winit_bin.exe` (exit code: 101) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A followup of #559
I see #559 (comment) indicates there's some plan of more significant rewrite, so please feel free to close this. This is mainly my practice of migration to winit's new API.
cf. changelog