Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial update to winit 0.30.0 #559

Merged

Conversation

waywardmonkeys
Copy link
Collaborator

This doesn't yet implement the new application handler trait.

This doesn't yet implement the new application handler trait.
@waywardmonkeys waywardmonkeys marked this pull request as ready for review May 1, 2024 10:51
@waywardmonkeys waywardmonkeys requested review from xStrom and xorgy May 1, 2024 10:51
@waywardmonkeys
Copy link
Collaborator Author

Marking this as ready for review in this form ... I really think that fixing it nicely will take rewriting a good chunk of with_winit which could happen incrementally.

@waywardmonkeys waywardmonkeys added this pull request to the merge queue May 1, 2024
Merged via the queue into linebender:main with commit 6b8ceef May 1, 2024
15 checks passed
@waywardmonkeys waywardmonkeys deleted the update-to-winit-0.30 branch May 1, 2024 12:04
@waywardmonkeys waywardmonkeys added this to the Vello 0.2 release milestone May 3, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 15, 2024
A followup of #559

I see
#559 (comment)
indicates there's some plan of more significant rewrite, so please feel
free to close this. This is mainly my practice of migration to winit's
new API.

cf.
[changelog](https://docs.rs/winit/latest/winit/changelog/index.html#deprecated)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants