Work around broken JS deps #392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI is failing because of some updated ecosystem crates that we don't care at all. This patch is a hammer to get it to stop failing, but is clearly not the right thing to do.
DJMcNab
reviewed
Oct 25, 2023
Comment on lines
+51
to
+53
| rustls-webpki = "=0.101.4" | ||
| sct = "=0.7.0" | ||
| ureq = "=2.7.1" |
There was a problem hiding this comment.
ring = { version = "0.17.5", features = ["wasm32_unknown_unknown_js"] }works for me. I suspect this is the correct behaviour. I'd also add a comment like:
# Tell our dependencies that we use wasm-bindgen and are running in a JavaScript host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is failing because of some updated ecosystem crates that we don't care about at all. This patch is a hammer to get it to stop failing, but is clearly not the right thing to do.