Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI is broken because dependencies upgraded #394

Closed
raphlinus opened this issue Oct 25, 2023 · 0 comments · Fixed by #395
Closed

CI is broken because dependencies upgraded #394

raphlinus opened this issue Oct 25, 2023 · 0 comments · Fixed by #395

Comments

@raphlinus
Copy link
Contributor

This command is failing and can be replicated locally after cargo update:

RUSTFLAGS=--cfg=web_sys_unstable_apis cargo check -p with_winit --target wasm32-unknown-unknown

The error is in the compilation of ring 0.17.5

warning: error: unable to create target: 'No available targets are compatible with triple "wasm32-unknown-unknown"'
warning: 1 error generated.

error: failed to run custom build command for `ring v0.17.5`

That in turn is depended on by rustls 0.21.8 and rustls-webpki 0.101.7, and sct 0.7.1, which come in through ureq, which is a dependency in our scenes crate to support the download feature.

I posted #392 yesterday, but I'm now thinking the proper fix is to remove the ureq dependency on wasm.
raphlinus added a commit that referenced this issue Oct 25, 2023
@raphlinus
Disable download feature on wasm
f937baf 
The download feature caused CI failures on wasm, due to dependencies breaking in ways difficult to diagnose. I searched the issues for the relevant dependencies and didn't find other people running into the same problem.

Since I worry that these deps may continue to be unstable, I think the best thing is to disable them on wasm builds. This shouldn't affect any functionality we actually care about.

Longer term, we probably want to move these more sophisticated examples out of the vello crate proper.

Fixes #394
@raphlinus raphlinus mentioned this issue Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable download feature on wasm linebender/vello
1 participant
@raphlinus