Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove refs from WebRenderContext constructor API #153

Merged
merged 1 commit into from
Apr 5, 2020
Merged

Remove refs from WebRenderContext constructor API #153

merged 1 commit into from
Apr 5, 2020

Commits on Mar 25, 2020

  1. Remove refs from WebRenderContext constructor API 

    Specifically, the lifetime of WebRenderContext is changed to not depend on lifetimes of CanvasRenderingContext2d and Window objects, since these lifetimes don't actually enforce the existence of web resources anyways.

The mut is also removed from CanvasRenderingContext2d since its API has
no mut calls and this generally makes the WebRenderContext difficult to use
in libraries like druid.

For compatibility the WebRenderContext maintains a phantom lifetime
placeholder for compatibility as well as for anticipating a correct
lifetime there.
    @elrnv
    elrnv committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    951407e View commit details
    Browse the repository at this point in the history