Remove refs from WebRenderContext constructor API #153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, the lifetime of
WebRenderContext
is changed to not depend on lifetimes ofCanvasRenderingContext2d
andWindow
objects, since these lifetimes don't actually enforce the existence of web resources anyways.The
mut
is also removed fromCanvasRenderingContext2d
since its API has nomut
calls and this generally makes theWebRenderContext
difficult to use in libraries like druid.For compatibility the
WebRenderContext
maintains a phantom lifetime placeholder for compatibility as well as for anticipating a correct lifetime there.