-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swash_render
not rendering on main
#114
Comments
I found this while trying to validate that dfrg/swash#61 didn't break anything... |
I'm pretty sure it should. I'm surprised CI didn't catch this! |
I'll submit a PR for it shortly. |
waywardmonkeys
added a commit
to waywardmonkeys/parley
that referenced
this issue
Sep 12, 2024
This line may have been mistakenly removed in linebender#106 (14070d5). Fix linebender#114.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@dfrg In 14070d5 (PR #106), you had this in your changes:
That wasn't done to the
tiny_skia_render
example and after this commit, thetiny_skia_render
example still renders, but theswash_render
does not.Restoring this line appears to let things still work...
Should this line be added back in? Should something else be fixed? Should the
tiny_skia_render
example be updated in some similar way if this change remains in place?The text was updated successfully, but these errors were encountered: