Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update yazi and zeno to current #61

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

waywardmonkeys
Copy link
Collaborator

No description provided.

@waywardmonkeys
Copy link
Collaborator Author

I tried to make sure that rendering still worked by using the swash_render example in Parley, but that was broken on main already.

@waywardmonkeys
Copy link
Collaborator Author

Doing a workaround in Parley to fix that example and then building with this version of swash still renders.

@waywardmonkeys
Copy link
Collaborator Author

@dfrg FYI

@dfrg
Copy link
Owner

dfrg commented Sep 23, 2024

I believe updating zeno is a semver breaking change since that crate is publicly re-exported. I’ve held off on doing this because I was trying to think of other breaking changes that might be valuable to include. At the very least, no_std support would be nice.

Since cosmic-text and its users depend on this, I’m trying to be conservative with breaking changes.

@waywardmonkeys
Copy link
Collaborator Author

At the very least, no_std support would be nice.

Hint received!

@waywardmonkeys
Copy link
Collaborator Author

Updated / rebased forward after 0.1.19.

Copy link
Collaborator

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this landed so that work on #63 can continue. Eventually landing no_std support here is crucial, as it is blocking Parley from getting no_std.

@dfrg dfrg merged commit bb8c583 into dfrg:main Nov 6, 2024
7 checks passed
@dfrg
Copy link
Owner

dfrg commented Nov 6, 2024

Thanks all and sorry for the delay. On a related note, would anyone like maintainer status on this repo to help land PRs?

@nicoburns
Copy link
Collaborator

Thanks all and sorry for the delay. On a related note, would anyone like maintainer status on this repo to help land PRs?

I would be up for this. I wouldn't necessarily be confident reviewing more invasive changes. But I could definitely help land lint fixes, dependency bumps, CI changes, and such. Perhaps it would be good if a couple of us had permissions (@waywardmonkeys? @xorgy? @xStrom?) then we could merge each other's PRs.

@dfrg
Copy link
Owner

dfrg commented Nov 7, 2024

Thanks Nico. Invite sent. I’m also happy to add any of the others you listed but I don’t want to foist responsibility on anyone.

@xorgy
Copy link
Collaborator

xorgy commented Nov 7, 2024

@dfrg I would like it, if for no other reason than to be able to label issues/pulls, and maybe go back and make tags and release notes.

@waywardmonkeys
Copy link
Collaborator Author

I can join the party too.

@dfrg
Copy link
Owner

dfrg commented Nov 7, 2024

Thanks, invites sent.

@xStrom
Copy link
Collaborator

xStrom commented Nov 7, 2024

Sure I'll take the invite too. I can do an occasional review.

@dfrg
Copy link
Owner

dfrg commented Nov 7, 2024

Thanks Kaur, sent to you as well. Looks like we’re in good shape for reviews now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants