-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: Update yazi
and zeno
to current
#61
Conversation
I tried to make sure that rendering still worked by using the |
Doing a workaround in Parley to fix that example and then building with this version of swash still renders. |
@dfrg FYI |
I believe updating zeno is a semver breaking change since that crate is publicly re-exported. I’ve held off on doing this because I was trying to think of other breaking changes that might be valuable to include. At the very least, no_std support would be nice. Since cosmic-text and its users depend on this, I’m trying to be conservative with breaking changes. |
Hint received! |
0f4bde3
to
c23be6b
Compare
c23be6b
to
ba840f2
Compare
Updated / rebased forward after 0.1.19. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this landed so that work on #63 can continue. Eventually landing no_std
support here is crucial, as it is blocking Parley from getting no_std
.
Thanks all and sorry for the delay. On a related note, would anyone like maintainer status on this repo to help land PRs? |
I would be up for this. I wouldn't necessarily be confident reviewing more invasive changes. But I could definitely help land lint fixes, dependency bumps, CI changes, and such. Perhaps it would be good if a couple of us had permissions (@waywardmonkeys? @xorgy? @xStrom?) then we could merge each other's PRs. |
Thanks Nico. Invite sent. I’m also happy to add any of the others you listed but I don’t want to foist responsibility on anyone. |
@dfrg I would like it, if for no other reason than to be able to label issues/pulls, and maybe go back and make tags and release notes. |
I can join the party too. |
Thanks, invites sent. |
Sure I'll take the invite too. I can do an occasional review. |
Thanks Kaur, sent to you as well. Looks like we’re in good shape for reviews now. |
No description provided.