Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change into_span! to trace_span! to reduce noise #2203

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Change into_span! to trace_span! to reduce noise #2203

merged 2 commits into from
Jul 8, 2022

Conversation

NickLarsenNZ
Copy link
Contributor

@NickLarsenNZ NickLarsenNZ commented Jun 11, 2022 •
edited
Loading

Closes #2202

image

@NickLarsenNZ
Copy link
Contributor Author

@cmyr I have followed the instructions from CONTRIBUTING.md. The pre-push hook passes, should be good to go.

cmyr
cmyr approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks, I agree that trace is probably a more appropriate level here.

Something we should consider is a convenience method on the AppLauncher that lets the user specify the log level; currently we always set the level to Debug.

@cmyr
Copy link
Member

cmyr commented Jul 5, 2022

@NickLarsenNZ can you rebase this when you get a chance?

@NickLarsenNZ
Copy link
Contributor Author

@cmyr

@NickLarsenNZ can you rebase this when you get a chance?

Done :)

@cmyr
Copy link
Member

cmyr commented Jul 5, 2022

@NickLarsenNZ did you maybe forget to push?

@NickLarsenNZ
Copy link
Contributor Author

Oh, sorry. I tried using the GitHub button to update. I'll sort that out soon.

@NickLarsenNZ
Copy link
Contributor Author

@cmyr I've rebased to the latest

@cmyr cmyr merged commit 380f1c5 into linebender:master Jul 8, 2022
xarvic pushed a commit to xarvic/druid that referenced this pull request Jul 29, 2022
@NickLarsenNZ @xarvic
Change into_span! to trace_span! to reduce noise (linebender#2203)
f0343a2 
* change into_span! to trace_span! to reduce noise linebender#2202

* add to changelog and authors list
xarvic pushed a commit to xarvic/druid that referenced this pull request Jul 29, 2022
@NickLarsenNZ @xarvic
Change into_span! to trace_span! to reduce noise (linebender#2203)
e3febb7 
* change into_span! to trace_span! to reduce noise linebender#2202

* add to changelog and authors list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event and Lifecycle spans should not be INFO level
2 participants
@NickLarsenNZ @cmyr