Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event and Lifecycle spans should not be INFO level #2202

Closed
NickLarsenNZ opened this issue Jun 11, 2022 · 1 comment · Fixed by #2203
Closed

Event and Lifecycle spans should not be INFO level #2202

NickLarsenNZ opened this issue Jun 11, 2022 · 1 comment · Fixed by #2203

Comments

@NickLarsenNZ
Copy link
Contributor

NickLarsenNZ commented Jun 11, 2022

These cause a lot of noise when implementing tracing output:

let _span = info_span!("event");

info_span!("lifecycle")

For example, when I move the mouse across the Window, a tonne of INFO level logs are outputted. I think these should be TRACE due to how noisy they can be. Note: some of the events are indeed TRACE.

image

@NickLarsenNZ NickLarsenNZ changed the title Event tracing should not be INFO level Event and Lifecycle spans should not be INFO level Jun 11, 2022
NickLarsenNZ added a commit to NickLarsenNZ/druid that referenced this issue Jun 11, 2022
NickLarsenNZ added a commit to NickLarsenNZ/druid that referenced this issue Jun 11, 2022
@cmyr
Copy link
Member

cmyr commented Jun 13, 2022

Something else that might be useful is to allow the user to pass a tracing level to the debug tracer, e.g. you would do,

AppLauncher::with_window(my_window)
    .log_to_console(LevelFilter::DEBUG)

NickLarsenNZ added a commit to NickLarsenNZ/druid that referenced this issue Jun 21, 2022
NickLarsenNZ added a commit to NickLarsenNZ/druid that referenced this issue Jul 5, 2022
@cmyr cmyr closed this as completed in #2203 Jul 8, 2022
cmyr pushed a commit that referenced this issue Jul 8, 2022
* change into_span! to trace_span! to reduce noise #2202

* add to changelog and authors list
xarvic pushed a commit to xarvic/druid that referenced this issue Jul 29, 2022
* change into_span! to trace_span! to reduce noise linebender#2202

* add to changelog and authors list
xarvic pushed a commit to xarvic/druid that referenced this issue Jul 29, 2022
* change into_span! to trace_span! to reduce noise linebender#2202

* add to changelog and authors list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants