Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Three tests often fail in CI builds.
com.linecorp.armeria.common.stream.StreamMessageCollectingTest.filteredStreamMessage_cancel()
#5942com.linecorp.armeria.server.Http1ServerDelayedCloseConnectionTest.shouldWaitForDisconnectByClientSideFirst()
#5724com.linecorp.armeria.client.DefaultDnsCacheTest.eviction()
#4960The cause of the failures seems to be a timing issue.
Modifications:
await().untilAsserted()
Result:
com.linecorp.armeria.common.stream.StreamMessageCollectingTest.filteredStreamMessage_cancel()
#5942com.linecorp.armeria.server.Http1ServerDelayedCloseConnectionTest.shouldWaitForDisconnectByClientSideFirst()
#5724com.linecorp.armeria.client.DefaultDnsCacheTest.eviction()
#4960