Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests #5943

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Fix flaky tests #5943

merged 2 commits into from
Oct 18, 2024

Conversation

Motivation:

Two tests often fail in CI builds.
- line#5942
- line#5724

The cause of the failtures seem timing issue.

Modifcations:

- Wrap assertion with `await().untilAsserted()`

Result:

- Fixes line#5942
- Fixes line#5724
@ikhoon ikhoon added the defect label Oct 16, 2024
@ikhoon ikhoon added this to the 1.31.0 milestone Oct 16, 2024
@ikhoon ikhoon added cleanup and removed defect labels Oct 16, 2024
@ikhoon ikhoon merged commit 411b6ae into line:main Oct 18, 2024
13 of 14 checks passed
@ikhoon ikhoon deleted the flaky-StreamMessageCollectingTest branch October 18, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants