Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure: com.linecorp.armeria.server.Http1ServerDelayedCloseConnectionTest.shouldWaitForDisconnectByClientSideFirst() #5724

Closed
minwoox opened this issue Jun 4, 2024 · 0 comments · Fixed by #5943
Closed

Test failure: com.linecorp.armeria.server.Http1ServerDelayedCloseConnectionTest.shouldWaitForDisconnectByClientSideFirst() #5724

minwoox opened this issue Jun 4, 2024 · 0 comments · Fixed by #5943

Comments

@minwoox
Copy link
Member

minwoox commented Jun 4, 2024 

org.opentest4j.AssertionFailedError: 
expected: 1
 but was: 2
	at [email protected]/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at [email protected]/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at app//com.linecorp.armeria.server.Http1ServerDelayedCloseConnectionTest.shouldWaitForDisconnectByClientSideFirst(Http1ServerDelayedCloseConnectionTest.java:112)
	at [email protected]/java.lang.reflect.Method.invoke(Method.java:580)
	at [email protected]/java.util.ArrayList.forEach(ArrayList.java:1596)
	at [email protected]/java.util.ArrayList.forEach(ArrayList.java:1596)
ikhoon added a commit to ikhoon/armeria that referenced this issue Oct 16, 2024
@ikhoon
Fix flaky tests
67d0176 
Motivation:

Two tests often fail in CI builds.
- line#5942
- line#5724

The cause of the failtures seem timing issue.

Modifcations:

- Wrap assertion with `await().untilAsserted()`

Result:

- Fixes line#5942
- Fixes line#5724
ikhoon added a commit to ikhoon/armeria that referenced this issue Oct 16, 2024
@ikhoon
Fix flaky tests
4db382a 
Motivation:

Two tests often fail in CI builds.
- line#5942
- line#5724

The cause of the failtures seem timing issue.

Modifcations:

- Wrap assertion with `await().untilAsserted()`

Result:

- Fixes line#5942
- Fixes line#5724
@ikhoon ikhoon mentioned this issue Oct 16, 2024
Merged
@ikhoon ikhoon closed this as completed in 411b6ae Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flaky tests ikhoon/armeria
1 participant
@minwoox