-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ClientFactory.numConnections() #3613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for working on this, @kojilin 🙇
core/src/main/java/com/linecorp/armeria/client/ClientFactory.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #3613 +/- ##
============================================
+ Coverage 73.81% 73.85% +0.04%
- Complexity 14356 14381 +25
============================================
Files 1260 1263 +3
Lines 54820 54878 +58
Branches 7022 7021 -1
============================================
+ Hits 40463 40528 +65
+ Misses 10785 10779 -6
+ Partials 3572 3571 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! @kojilin
core/src/test/java/com/linecorp/armeria/client/HttpClientFactoryTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍 👍
Motivation:
It's be nice if
ClientFactory
hasnumConnections()
likeServer
,so that a user can easily figure out how many connections it is managing.
Modifications:
Clientfactory.numConnections()
, get connection count from allChannels directly.Result:
ClientFactory.numConnections()
#3596