Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ClientFactory.numConnections() #3596

Closed
trustin opened this issue Jun 1, 2021 · 0 comments · Fixed by #3613
Closed

Add ClientFactory.numConnections() #3596

trustin opened this issue Jun 1, 2021 · 0 comments · Fixed by #3613
Labels
new feature
Milestone
1.9.0

Comments

@trustin
Copy link
Member

trustin commented Jun 1, 2021

.. like Server has numConnections(), so that a user can easily figure out how many connections it is managing.
@trustin trustin added this to the 1.9.0 milestone Jun 1, 2021
@kojilin kojilin mentioned this issue Jun 5, 2021
Merged
trustin pushed a commit that referenced this issue Jun 14, 2021
@kojilin
Add ClientFactory.numConnections() (#3613)
35473d2 
Motivation:

It's be nice if `ClientFactory` has `numConnections()` like `Server`,
so that a user can easily figure out how many connections it is managing.

Modifications:

- Add `Clientfactory.numConnections()`, get connection count from allChannels directly.
- Add test for multiple h1c request & multie servers

Result:

- Closes #3596
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
1.9.0
Development

Successfully merging a pull request may close this issue.

Add ClientFactory.numConnections() kojilin/armeria
1 participant
@trustin