CacheResolver #184
Merged
CacheResolver #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iamdto @Maxwell2022 @lsmith77 What do you think about it? |
| */ | ||
| public function clear($cachePrefix) | ||
| { | ||
| // TODO: implement cache clearing |
There was a problem hiding this comment.
This one is tricky, as the $cachePrefix does not correlate to a given scheme to reflect a subset of targetPaths on the resolver in use. I think, if someone needs this, he would need to add a sub-class and override this method according to the resolver in use.
|
Didn't test it, but looks good so far. |
|
We activated it, and it's working nicely, so I'm gonna merge the current version for a start. |
|
Thanks 👍 ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #183