Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add append feature for sqlite on load fixtures method #393

Merged
merged 1 commit into from
Feb 15, 2018

Conversation

almacbe
Copy link
Contributor

@almacbe almacbe commented Feb 8, 2018

I realize that I forget to add the append feature to SQLite. I've added it to this PR.

@almacbe
Copy link
Contributor Author

almacbe commented Feb 8, 2018

And... how could I test this feature? I am not sure how to create a test in an environment with SQLite config.

@alexislefebvre
Copy link
Collaborator

Default configuration of tests uses SQLite:

There is also some tests with MySQL, they are marked with @group mysql and they are ignored by default:

But Travis CI launch them:

# In phpunit.xml.dist, tests annotated with "@group mysql" are excluded,

So as long as a test use the append feature, it will be tested with SQLite.

@almacbe almacbe force-pushed the allow-append-sqlite branch from 62bfaf9 to afddaec Compare February 8, 2018 18:10
@almacbe
Copy link
Contributor Author

almacbe commented Feb 8, 2018

I have added the test.

@almacbe
Copy link
Contributor Author

almacbe commented Feb 15, 2018

Do you have some update about this PR?

@alexislefebvre alexislefebvre merged commit 6f935f6 into liip:2.x Feb 15, 2018
@alexislefebvre
Copy link
Collaborator

Thanks!

@almacbe almacbe deleted the allow-append-sqlite branch February 15, 2018 11:32
alekseytupichenkov pushed a commit to alekseytupichenkov/LiipFunctionalTestBundle that referenced this pull request Feb 18, 2018
alekseytupichenkov pushed a commit to alekseytupichenkov/LiipFunctionalTestBundle that referenced this pull request Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants