FlintCI integration

.flintci.yml

@@ -0,0 +1,3 @@
+services:
+  phpcsfixer: true
+  yamllint: true

.gitignore

@@ -1,5 +1,6 @@
 composer.lock
 vendor
+.php_cs.cache
 
 # Ignore files created during tests
 /tests/App*/cache/*

.php_cs.dist

@@ -0,0 +1,32 @@
+<?php
+
+$finder = PhpCsFixer\Finder::create()
+    ->in(__DIR__)
+    ->notPath('/cache/')
+;
+
+return PhpCsFixer\Config::create()
+    ->setFinder($finder)
+    ->setRiskyAllowed(true)
+    ->setRules([
+        '@Symfony' => true,
+        '@Symfony:risky' => true,
+        'array_syntax' => [
+            'syntax' => 'short',
+        ],
+        'combine_consecutive_issets' => true,
+        'combine_consecutive_unsets' => true,
+        'no_extra_consecutive_blank_lines' => true,
+        'no_php4_constructor' => true,
+        'no_useless_else' => true,
+        'no_useless_return' => true,
+        'ordered_imports' => true,
+        'phpdoc_order' => true,
+        '@PHP56Migration' => true,
+        '@PHP56Migration:risky' => true,
+        'strict_comparison' => true,
+        'strict_param' => true,
+        'php_unit_strict' => true,
+    ])
+    ->setUsingCache(true)
+;

.scrutinizer.yml

@@ -27,7 +27,7 @@ build:
       version: 5.6
   dependencies:
     override:
-      - 
+      -
         command: 'composer require --dev "symfony/symfony:2.8.*" --no-update'
       -
         command: 'composer update --no-interaction -vv --profile --no-progress'

.yamllint

@@ -0,0 +1,20 @@
+extends: default
+
+ignore: |
+  /vendor/
+
+rules:
+  braces:
+    min-spaces-inside: 1
+    max-spaces-inside: 1
+  brackets:
+    min-spaces-inside: 0
+    max-spaces-inside: 1
+  colons:
+    max-spaces-after: -1
+  document-start: disable
+  line-length:
+    max: 120
+    level: warning
+    ignore: |
+      /.travis.yml

ExampleTests/ExampleFunctionalTest.php

@@ -25,7 +25,7 @@ class ExampleFunctionalTest extends WebTestCase
      */
     public function testUserFooIndex()
     {
-        $this->loadFixtures(array('Liip\FooBundle\Tests\Fixtures\LoadUserData'));
+        $this->loadFixtures(['Liip\FooBundle\Tests\Fixtures\LoadUserData']);
 
         $client = $this->createClient();
         $crawler = $client->request('GET', '/users/foo');
@@ -39,10 +39,10 @@ public function testUserFooIndex()
      */
     public function testBasicAuthentication()
     {
-        $this->loadFixtures(array('Liip\FooBundle\Tests\Fixtures\LoadUserData'));
+        $this->loadFixtures(['Liip\FooBundle\Tests\Fixtures\LoadUserData']);
 
         $content = $this->fetchContent('/users/foo', 'GET', true);
-        $this->assertEquals('Hello foo!', $content);
+        $this->assertSame('Hello foo!', $content);
 
         // check if the logout button is shown
         $this->assertContains('logout', $content);
@@ -66,6 +66,6 @@ public function testValidationErrors()
 
         $client->submit($crawler->selectButton('Save')->form());
 
-        $this->assertValidationErrors(array('data.username', 'data.email'), $client->getContainer());
+        $this->assertValidationErrors(['data.username', 'data.email'], $client->getContainer());
     }
 }

ExampleTests/ExampleHtml5Test.php

@@ -30,16 +30,16 @@ public function testIndex()
 
     public function testBasicAuthentication()
     {
-        $this->loadFixtures(array('Liip\FooBundle\Tests\Fixtures\LoadUserData'));
+        $this->loadFixtures(['Liip\FooBundle\Tests\Fixtures\LoadUserData']);
 
         $content = $this->fetchContent('/', 'GET', true);
-        $this->assertEquals('Hello foo!', $content);
+        $this->assertSame('Hello foo!', $content);
     }
 
     public function testGenerateInMissingDir()
     {
-        $this->runCommand('main:generate-html', array('output-dir' => './doesntexist'));
-        $this->assertFalse(file_exists($this->dir.'/index.html'));
+        $this->runCommand('main:generate-html', ['output-dir' => './doesntexist']);
+        $this->assertFileNotExists($this->dir.'/index.html');
     }
 
     public function testIndexAction()
@@ -60,6 +60,6 @@ public function testIndexAction()
 
         $controller = new DefaultController($view);
 
-        $this->assertEquals('success', $controller->indexAction());
+        $this->assertSame('success', $controller->indexAction());
     }
 }

ExampleTests/ExampleUnitTest.php

@@ -41,6 +41,6 @@ public function testIndexAction()
 
         $controller = new DefaultController($view);
 
-        $this->assertEquals('success', $controller->indexAction());
+        $this->assertSame('success', $controller->indexAction());
     }
 }

ExampleTests/Fixtures/LoadUserData.php

@@ -11,10 +11,10 @@
 
 namespace Liip\FooBundle\Tests\Fixtures;
 
-use Doctrine\ORM\EntityManager;
 use Doctrine\Common\DataFixtures\FixtureInterface;
-use Symfony\Component\Security\Core\Encoder\MessageDigestPasswordEncoder;
 use Doctrine\Common\Persistence\ObjectManager;
+use Doctrine\ORM\EntityManager;
+use Symfony\Component\Security\Core\Encoder\MessageDigestPasswordEncoder;
 
 /**
  * @author Lea Haensenberger

src/Command/RunParatestCommand.php

@@ -3,12 +3,12 @@
 namespace Liip\FunctionalTestBundle\Command;
 
 use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
+use Symfony\Bundle\FrameworkBundle\Console\Application;
+use Symfony\Component\Console\Input\ArrayInput;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Process\Process;
-use Symfony\Component\Console\Input\ArrayInput;
-use Symfony\Bundle\FrameworkBundle\Console\Application;
 
 /**
  * Command used to update the project.
@@ -49,15 +49,15 @@ protected function prepare()
         $cleanProcess->run();
         $this->output->writeln("Creating Schema in $this->testDbPath ...");
         $application = new Application($this->getContainer()->get('kernel'));
-        $input = new ArrayInput(array('doctrine:schema:create', '--env' => 'test'));
+        $input = new ArrayInput(['doctrine:schema:create', '--env' => 'test']);
         $application->run($input, $this->output);
 
         $this->output->writeln('Initial schema created');
-        $input = new ArrayInput(array(
+        $input = new ArrayInput([
             'doctrine:fixtures:load',
             '-n' => '',
             '--env' => 'test',
-        ));
+        ]);
         $application->run($input, $this->output);
 
         $this->output->writeln('Initial schema populated, duplicating....');

src/Command/TestCommand.php

@@ -78,7 +78,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 $output->writeln('Verbosity level: VERY_VERBOSE');
             }
 
-            if (OutputInterface::VERBOSITY_DEBUG == $output->getVerbosity()) {
+            if (OutputInterface::VERBOSITY_DEBUG === $output->getVerbosity()) {
                 $output->writeln('Verbosity level: DEBUG');
             }
         }

src/DependencyInjection/Compiler/OptionalValidatorPass.php

@@ -2,8 +2,8 @@
 
 namespace Liip\FunctionalTestBundle\DependencyInjection\Compiler;
 
-use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
 
 class OptionalValidatorPass implements CompilerPassInterface
 {

src/DependencyInjection/Compiler/SetTestClientPass.php

@@ -2,9 +2,9 @@
 
 namespace Liip\FunctionalTestBundle\DependencyInjection\Compiler;
 
-use Symfony\Component\DependencyInjection\ContainerBuilder;
-use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
 use Symfony\Component\DependencyInjection\Alias;
+use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
 
 class SetTestClientPass implements CompilerPassInterface
 {

src/DependencyInjection/Configuration.php

@@ -11,8 +11,8 @@
 
 namespace Liip\FunctionalTestBundle\DependencyInjection;
 
-use Symfony\Component\Config\Definition\ConfigurationInterface;
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
+use Symfony\Component\Config\Definition\ConfigurationInterface;
 
 /**
  * This class contains the configuration information for the bundle.
@@ -71,11 +71,11 @@ public function getConfigTreeBuilder()
                         ->end()
                         ->arrayNode('ignores')
                             ->prototype('scalar')->end()
-                            ->defaultValue(array())
+                            ->defaultValue([])
                         ->end()
                         ->arrayNode('ignores_extract')
                             ->prototype('scalar')->end()
-                            ->defaultValue(array())
+                            ->defaultValue([])
                         ->end()
                     ->end()
                 ->end()

src/DependencyInjection/LiipFunctionalTestExtension.php

@@ -11,10 +11,10 @@
 
 namespace Liip\FunctionalTestBundle\DependencyInjection;
 
-use Symfony\Component\HttpKernel\DependencyInjection\Extension;
-use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
-use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\Config\FileLocator;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
+use Symfony\Component\HttpKernel\DependencyInjection\Extension;
 
 class LiipFunctionalTestExtension extends Extension
 {

src/EventListener/ExceptionListener.php

@@ -31,7 +31,7 @@ public function setException(GetResponseForExceptionEvent $event)
 
     public function clearLastException(GetResponseEvent $event)
     {
-        if (HttpKernelInterface::MASTER_REQUEST == $event->getRequestType()) {
+        if (HttpKernelInterface::MASTER_REQUEST === $event->getRequestType()) {
             $this->lastException = null;
         }
     }
@@ -43,9 +43,9 @@ public function getLastException()
 
     public static function getSubscribedEvents()
     {
-        return array(
-            KernelEvents::EXCEPTION => array('setException', 99999),
-            KernelEvents::REQUEST => array('clearLastException', 99999),
-        );
+        return [
+            KernelEvents::EXCEPTION => ['setException', 99999],
+            KernelEvents::REQUEST => ['clearLastException', 99999],
+        ];
     }
 }

src/Factory/ConnectionFactory.php

@@ -22,7 +22,7 @@ class ConnectionFactory extends BaseConnectionFactory
      *
      * @return \Doctrine\DBAL\Connection
      */
-    public function createConnection(array $params, Configuration $config = null, EventManager $eventManager = null, array $mappingTypes = array())
+    public function createConnection(array $params, Configuration $config = null, EventManager $eventManager = null, array $mappingTypes = [])
     {
         $dbName = $this->getDbNameFromEnv($params['dbname']);
 

src/LiipFunctionalTestBundle.php

@@ -11,10 +11,10 @@
 
 namespace Liip\FunctionalTestBundle;
 
-use Symfony\Component\HttpKernel\Bundle\Bundle;
-use Symfony\Component\DependencyInjection\ContainerBuilder;
-use Liip\FunctionalTestBundle\DependencyInjection\Compiler\SetTestClientPass;
 use Liip\FunctionalTestBundle\DependencyInjection\Compiler\OptionalValidatorPass;
+use Liip\FunctionalTestBundle\DependencyInjection\Compiler\SetTestClientPass;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\HttpKernel\Bundle\Bundle;
 
 class LiipFunctionalTestBundle extends Bundle
 {

src/QueryCountClient.php

@@ -17,9 +17,9 @@ public function setQueryCounter(QueryCounter $queryCounter)
     public function request(
         $method,
         $uri,
-        array $parameters = array(),
-        array $files = array(),
-        array $server = array(),
+        array $parameters = [],
+        array $files = [],
+        array $server = [],
         $content = null,
         $changeHistory = true
     ) {

src/Test/Html5WebTestCase.php

@@ -39,7 +39,7 @@ abstract class Html5WebTestCase extends WebTestCase
 
     protected $validationServiceAvailable = false;
 
-    public function __construct($name = null, array $data = array(), $dataName = '')
+    public function __construct($name = null, array $data = [], $dataName = '')
     {
         parent::__construct($name, $data, $dataName);
 
@@ -105,11 +105,11 @@ public function validateHtml5($content)
         curl_setopt($ch, CURLOPT_URL, $validationUrl);
         curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
         curl_setopt($ch, CURLOPT_POST, true);
-        curl_setopt($ch, CURLOPT_POSTFIELDS, array(
+        curl_setopt($ch, CURLOPT_POSTFIELDS, [
             'out' => 'json',
             'parser' => 'html5',
             'content' => $content,
-        ));
+        ]);
 
         $res = curl_exec($ch);
 
@@ -152,7 +152,7 @@ public function assertIsValidHtml5($content, $message = '')
 
         $err_count = 0;
         $err_msg = 'HTML5 validation failed';
-        if ('' != $message) {
+        if ('' !== $message) {
             $err_msg .= " [$message]";
         }
         $err_msg .= ":\n";
@@ -165,7 +165,7 @@ public function assertIsValidHtml5($content, $message = '')
         $ignores_extract = $this->getContainer()->getParameter('liip_functional_test.html5validation.ignores_extract');
 
         foreach ($res->messages as $row) {
-            if ('error' == $row->type) {
+            if ('error' === $row->type) {
                 foreach ($ignores as $ignore) {
                     if (preg_match($ignore, $row->message)) {
                         continue 2;
@@ -185,7 +185,7 @@ public function assertIsValidHtml5($content, $message = '')
                 }
             }
         }
-        $this->assertTrue(0 == $err_count, $err_msg);
+        $this->assertTrue(0 === $err_count, $err_msg);
     }
 
     /**

src/Test/ValidationErrorsConstraint.php

@@ -48,15 +48,15 @@ public function __construct(array $expect)
      */
     public function evaluate($other, $description = '', $returnResult = false)
     {
-        $actual = array();
+        $actual = [];
 
         foreach ($other as $error) {
             $actual[$error->getPropertyPath()][] = $error->getMessage();
         }
 
         ksort($actual);
 
-        if (array_keys($actual) == $this->expect) {
+        if (array_keys($actual) === $this->expect) {
             return true;
         }
 
@@ -71,7 +71,7 @@ public function evaluate($other, $description = '', $returnResult = false)
         );
         sort($mismatchedKeys);
 
-        $lines = array();
+        $lines = [];
 
         foreach ($mismatchedKeys as $key) {
             if (isset($actual[$key])) {