[WIP] Remove outdated code in Html5WebTestCase #373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexislefebvre
force-pushed
the
remove-outdated-code-in-Html5WebTestCase-2.x
branch
from
fa279bd to
cd52444
Compare
|
yes. lets kick the html5 validation feature. if at all it should live in its own bundle. |
|
Great, I'll remove all the HTML validation part. I'll have to document that somewhere. |
|
You also need to include #370 (or rebase on master, since it's merged) to avoid conflicts. |
alexislefebvre
deleted the
remove-outdated-code-in-Html5WebTestCase-2.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #251
Maybe we should remove all the code related to HTML5 validation? What do you think @lsmith77 and others? Thanks.