Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old code with comment "this stuff should go away"? #251

Closed
alexislefebvre opened this issue Mar 5, 2016 · 2 comments
Closed

Remove old code with comment "this stuff should go away"? #251

alexislefebvre opened this issue Mar 5, 2016 · 2 comments
Assignees
Milestone

Comments

@alexislefebvre
Copy link
Collaborator

I found a surprising comment in Test/Html5WebTestCase.php (example in 1.5 version):

/*
 * unfortunately, the bamboo html5 validator.nu gives back an empty "message" about the error with brightcove object, but we have to ignore the error
 * if our local validator.nu instance is fixed, this stuff should go away
 */
$ignores_extract = $this->getContainer()->getParameter('liip_functional_test.html5validation.ignores_extract');

Should this code be removed?

It was added 5 years ago: a4a9190

@alexislefebvre alexislefebvre changed the title Remove legacy code with comment "this stuff should go away"? Remove old code with comment "this stuff should go away"? Mar 5, 2016
@lsmith77
Copy link
Contributor

yeah .. probably.

alexislefebvre added a commit to alexislefebvre/LiipFunctionalTestBundle that referenced this issue Feb 19, 2017
@alexislefebvre alexislefebvre added this to the 2.0 milestone Dec 11, 2017
alexislefebvre added a commit that referenced this issue Jan 10, 2018
alexislefebvre added a commit to alexislefebvre/LiipFunctionalTestBundle that referenced this issue Jan 10, 2018
@alexislefebvre
Copy link
Collaborator Author

Fixed by #375.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants