Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v1.0.0-RC1 #58

Merged
merged 6 commits into from
Jun 22, 2021
Merged

Update to v1.0.0-RC1 #58

merged 6 commits into from
Jun 22, 2021

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Jun 22, 2021

Description:

To upgrade to 1.0.0-RC1, this:

  1. splits the exporter into trace and metric exporters
  2. adopts changes in the OTel-Go resource API

Repairs some misleading example code in the tracing example.

Link to tracking Issue:
Fixes #33
Fixes #55

Testing:
Viewed a trace in Lightstep, read the debugging output w/ OTEL_LOG_LEVEL=debug.

Documentation:
none

@jmacd jmacd requested a review from codeboten June 22, 2021 06:57
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2021

Codecov Report

Merging #58 (6eae065) into main (4686d49) will decrease coverage by 0.59%.
The diff coverage is 93.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   92.14%   91.54%   -0.60%     
==========================================
  Files           3        3              
  Lines         280      284       +4     
==========================================
+ Hits          258      260       +2     
- Misses         11       12       +1     
- Partials       11       12       +1     
Impacted Files Coverage Δ
launcher/config.go 89.52% <90.00%> (-0.38%) ⬇️
examples/tracing/trace.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4686d49...6eae065. Read the comment docs.

launcher/config.go Show resolved Hide resolved
@jmacd jmacd merged commit 2697f79 into main Jun 22, 2021
@jmacd jmacd deleted the jmacd/update_rc1 branch June 22, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants