Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTEL_RESOURCE_LABELS is now supported in opentelemetry-go, can drop launcher support? #55

Closed
tobert opened this issue Apr 9, 2021 · 1 comment · Fixed by #58
Closed

OTEL_RESOURCE_LABELS is now supported in opentelemetry-go, can drop launcher support? #55

tobert opened this issue Apr 9, 2021 · 1 comment · Fixed by #58

Comments

@tobert
Copy link
Contributor

tobert commented Apr 9, 2021

I was looking at the launcher source code and noticed this line, went to look at the issue it mentions and it says it was closed last year. I forget about these things all the time so I thought I'd drop an issue so y'all can take care of it.

otel-launcher-go/launcher/config.go

Line 294 in 103307c

// workaround until the following change is released

open-telemetry/opentelemetry-go#1042
@codeboten
Copy link
Contributor

Thanks for opening this issue @tobert!

@jmacd jmacd mentioned this issue Jun 22, 2021
Merged
@jmacd jmacd closed this as completed in #58 Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to v1.0.0-RC1 lightstep/otel-launcher-go
2 participants
@codeboten @tobert