payload signer signatures #417
Conversation
…enabled adding pre-built signatures onto a transaction
| //XOR the new hint with this keypair's public key hint | ||
| for (int i = 0; i < hint.length; i++) { | ||
| hint[i] ^= (i < payloadSignature.getHint().getSignatureHint().length ? payloadSignature.getHint().getSignatureHint()[i] : 0); | ||
| } |
There was a problem hiding this comment.
❓ I'm a bit confused by this. It looks like there's a condition here to handle the payloadSignature having a too short hint, however the too short hint is handled a few lines above already. Hints are always 4 bytes. A SignatureHint should never contain a hint shorter.
There was a problem hiding this comment.
payloadSignature.getHint().getSignatureHint() refers to the key hint, it was paranoid defensive guard on that key hint array being shorter than the payload hint array, fine with removing it for cleaner approach here.
There was a problem hiding this comment.
Yeah I think you can remove the check. Hint's should always be 4 bytes. In other languages where we can guarantee the length of the byte[] is 4 we do that, I guess in Java we can't?
There was a problem hiding this comment.
java array type doesn't include the dimension as part of the type declaration and the generated xdr.SignatureHint doesn't have any checks on the size. it would require decorator or other wrapper class in the sdk around xdr.SignatureHint that enforces the length dimension. I removed that guard check.
| (byte)(255), | ||
| (byte)(0xFF & 64), | ||
| (byte)(0xFF & 7), | ||
| (byte)(0xFF & 55)}); |
There was a problem hiding this comment.
❓ What is the 0xFF here for? Isn't 0xff & 64 = 0x64? I think you can simply do:
| (byte)(255), | |
| (byte)(0xFF & 64), | |
| (byte)(0xFF & 7), | |
| (byte)(0xFF & 55)}); | |
| (byte)(255), | |
| (byte)(64), | |
| (byte)(7), | |
| (byte)(55)}); |
See this as an example: https://go.dev/play/p/qi-HubnfmPA
There was a problem hiding this comment.
yes, wasn't necessary, wanted to show the 8 bit unsigned value being placed into each byte, and did used that form for all values even the ones below 128
… and cleaned up byte expressions in test
As part of CAP-40, needed to include payload signer signature generation from
KeyPairand separate way to add pre-built signatures onto aTransaction.