Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update StrKey implementation to support CAP-40 signed payloads #410

Closed
Tracked by #4261
Shaptic opened this issue Mar 14, 2022 · 3 comments · Fixed by #416
Closed
Tracked by #4261

Update StrKey implementation to support CAP-40 signed payloads #410

Shaptic opened this issue Mar 14, 2022 · 3 comments · Fixed by #416
Assignees
@sreuland
Labels
Protocol 19

Comments

@Shaptic
Copy link
Contributor

Shaptic commented Mar 14, 2022

Java-specific issue for the parent, stellar/go#4262.
@Shaptic Shaptic moved this to Todo in Protocol 19 Mar 14, 2022
@Shaptic Shaptic mentioned this issue Mar 14, 2022
Closed
3 tasks
@Shaptic Shaptic removed this from Protocol 19 Mar 14, 2022
@Shaptic Shaptic mentioned this issue Mar 14, 2022
Closed
15 tasks
@sreuland sreuland self-assigned this Mar 16, 2022
This was referenced Mar 16, 2022
Closed
Closed
sreuland added a commit to sreuland/java-stellar-sdk that referenced this issue Mar 21, 2022
@sreuland
lightsail-network#410: updated xdr definitions for Protocol 19, add S…
90f3ad5 
…ignedPayload Signer from CAP40 into StrKey encoding/decoding.
@sreuland sreuland mentioned this issue Mar 21, 2022
Closed
sreuland added a commit to sreuland/java-stellar-sdk that referenced this issue Mar 21, 2022
@sreuland
lightsail-network#410: use xdr data types for predicate time dimensio…
5bf518b 
…ns, incorporate some pr feedback
sreuland added a commit to sreuland/java-stellar-sdk that referenced this issue Mar 22, 2022
@sreuland
lightsail-network#410: use xdr encoding/decoding for signed payload (…
c44b1de 
…de)ser, use AccountID for signed payload pojo to check discriminant on public key types
sreuland added a commit to sreuland/java-stellar-sdk that referenced this issue Mar 22, 2022
@sreuland
lightsail-network#410: maintain backwards compliant Predicate
163b582
sreuland added a commit to sreuland/java-stellar-sdk that referenced this issue Mar 23, 2022
@sreuland
lightsail-network#410: renamed parameter to 'signer' per feedback on pr
1717767
sreuland added a commit to sreuland/java-stellar-sdk that referenced this issue Mar 23, 2022
@sreuland
lightsail-network#410: regenerated all xdr from latest .x source on p…
49b477d 
…19 branch
sreuland added a commit to sreuland/java-stellar-sdk that referenced this issue Mar 24, 2022
@sreuland
lightsail-network#410: consolidate validation of signed payload aspec…
c61a5d5 
…ts into SignedPayloadSigner, pr feedback
@sreuland sreuland mentioned this issue Mar 24, 2022
Merged
@Shaptic
Copy link
Contributor Author

Shaptic commented Mar 24, 2022

Closed by #414.

@Shaptic Shaptic closed this as completed Mar 24, 2022
@sreuland sreuland mentioned this issue Mar 25, 2022
Merged
sreuland added a commit to sreuland/java-stellar-sdk that referenced this issue Apr 8, 2022
@sreuland
lightsail-network#410: added payload signer signature generation and …
4ed57f3 
…enabled adding pre-built signatures onto a transaction
sreuland added a commit to sreuland/java-stellar-sdk that referenced this issue Apr 8, 2022
@sreuland
lightsail-network#410: removed unnecessary guard check on hint length…
e6e1966 
… and cleaned up byte expressions in test
vinamogit pushed a commit to vinamogit/java-stellar-sdk that referenced this issue Apr 30, 2022
@sreuland
lightsail-network#410: renamed parameter to 'signer' per feedback on pr
491aba8
vinamogit pushed a commit to vinamogit/java-stellar-sdk that referenced this issue Apr 30, 2022
@sreuland
lightsail-network#410: regenerated all xdr from latest .x source on p…
419b03f 
…19 branch
vinamogit pushed a commit to vinamogit/java-stellar-sdk that referenced this issue Apr 30, 2022
@sreuland
lightsail-network#410: consolidate validation of signed payload aspec…
931a975 
…ts into SignedPayloadSigner, pr feedback
vinamogit pushed a commit to vinamogit/java-stellar-sdk that referenced this issue Apr 30, 2022
@sreuland
lightsail-network#410: added payload signer signature generation and …
ee3b7ba 
…enabled adding pre-built signatures onto a transaction
vinamogit pushed a commit to vinamogit/java-stellar-sdk that referenced this issue Apr 30, 2022
@sreuland
lightsail-network#410: removed unnecessary guard check on hint length…
e091847 
… and cleaned up byte expressions in test
@nkavian
Copy link

nkavian commented Sep 24, 2022

@sreuland This PR made the signers list immutable. We need the ability to clear the signers and get the unsigned structure.

  • Could we get a clearSignatures() method added to the class?
  • Is there an alternate way to clear signatures?

@nkavian nkavian mentioned this issue Sep 24, 2022
Closed
@sreuland
Copy link
Contributor

@sreuland This PR made the signers list immutable. We need the ability to clear the signers and get the unsigned structure.

  • Could we get a clearSignatures() method added to the class?
  • Is there an alternate way to clear signatures?

Hello @nkavian , I responded on issue #456 with suggestions on some alternatives, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sreuland sreuland

Labels
Protocol 19
Projects
None yet
Milestone
No milestone
3 participants
@Shaptic @nkavian @sreuland