lnwallet: update Bolt3 test vectors #7439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
force-pushed
the
bolt3-test-vectors
branch
2 times, most recently
from
7701631
to
3977c35
Compare
ellemouton
force-pushed
the
bolt3-test-vectors
branch
from
3977c35
to
2659659
Compare
|
Just FYI: the Bolts PR got merged. Can confirm that LDK & Eclair match with these vectors |
yyforyongyu
approved these changes
Feb 28, 2023
| test := test | ||
| for _, test := range testCases { | ||
| test := test | ||
| name := fmt.Sprintf("%s-%s", set.name, test.Name) |
| @@ -251,6 +303,18 @@ func addTestHtlcs(t *testing.T, remote, | |||
| func testVectors(t *testing.T, chanType channeldb.ChannelType, test testCase) { | |||
| tc := newTestContext(t) | |||
|
|
|||
| // Determine which htlc set to use. | |||
| testHtlcs := testHtlcsSet1 | |||
| if strings.Contains(test.Name, "same amount and preimage") { | |||
There was a problem hiding this comment.
yeah - weird I know 🙃 but the spec does actually define this test like this 🙈
In this commit, an assertion is added to the bolt 3 commitment tx tests that ensures that the local and remote balances add up to the expected funding amount. Adding this assertion uncovered a borked test vector which is also fixed in this commit.
Add a new test htlc set comprised of htlc 1 from the original set and two new htlcs, 5 and 6, that use the same preimage and have the same output value (in sats). This htlc set is used in tests that assert the ordering of htlcs that have the same preimage and output value.
ellemouton
force-pushed
the
bolt3-test-vectors
branch
from
2659659
to
05793e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates adds the
option-zero-fee-htlc-txtest vectors.It also adds the new "same amount and preimage" tests that were missing from the existing legacy and anchor tests.
Fixes #7407