-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lnwallet: update Bolt3 test vectors #7439
Merged
guggero
merged 9 commits into
lightningnetwork:0-16-1-staging
from
ellemouton:bolt3-test-vectors
Mar 16, 2023
Merged
lnwallet: update Bolt3 test vectors #7439
guggero
merged 9 commits into
lightningnetwork:0-16-1-staging
from
ellemouton:bolt3-test-vectors
Mar 16, 2023
Commits on Mar 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b5d281d - Browse repository at this point
Copy the full SHA b5d281dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 15da50d - Browse repository at this point
Copy the full SHA 15da50dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09ff853 - Browse repository at this point
Copy the full SHA 09ff853View commit details -
lnwallet: add funding amount assertion to tests
In this commit, an assertion is added to the bolt 3 commitment tx tests that ensures that the local and remote balances add up to the expected funding amount. Adding this assertion uncovered a borked test vector which is also fixed in this commit.
Configuration menu - View commit details
-
Copy full SHA for dbc19b2 - Browse repository at this point
Copy the full SHA dbc19b2View commit details -
lnwallet: add new htlc set for test vectors
Add a new test htlc set comprised of htlc 1 from the original set and two new htlcs, 5 and 6, that use the same preimage and have the same output value (in sats). This htlc set is used in tests that assert the ordering of htlcs that have the same preimage and output value.
Configuration menu - View commit details
-
Copy full SHA for 4f14193 - Browse repository at this point
Copy the full SHA 4f14193View commit details -
Configuration menu - View commit details
-
Copy full SHA for a41f6d5 - Browse repository at this point
Copy the full SHA a41f6d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6774b72 - Browse repository at this point
Copy the full SHA 6774b72View commit details -
Configuration menu - View commit details
-
Copy full SHA for b607db3 - Browse repository at this point
Copy the full SHA b607db3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05793e5 - Browse repository at this point
Copy the full SHA 05793e5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.