Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add litecoin regtest to lnd #2189

Merged
merged 1 commit into from
Apr 29, 2019
Merged

add litecoin regtest to lnd #2189

merged 1 commit into from
Apr 29, 2019

Conversation

dannypaz
Copy link
Contributor

@dannypaz dannypaz commented Nov 15, 2018 •
edited
Loading

This PR enables regtest mode for ltcd/litecoind in lnd.

Related PRs:
ltcsuite/ltcd#10 was recently merged into LTCD to prevent failures of invalid genesis block.
LTCD archived the issue here: ltcsuite-archive/ltcd#10

Changes include:

  1. Updating LTCD version in lnd
  2. Adding regtest configuration to config.go
  3. renaming regtestNetParams to bitcoinRegTestNetParams

@Roasbeef Roasbeef added enhancement Improvements to existing features / behaviour testing Improvements/modifications to the test suite litecoin needs review PR needs review by regular contributors needs testing PR hasn't yet been actively tested on testnet/mainnet labels Nov 27, 2018
@dannypaz
Copy link
Contributor Author

Dupe of #1996 however additional changes were made

@dannypaz dannypaz force-pushed the sparkswap/litecoin-regtest branch from ef2108c to c1958a8 Compare November 29, 2018 21:53
@dannypaz
Copy link
Contributor Author

@Roasbeef et.al, I reviewed adding specs and most of this code is untested. Is there anything else that needs to be done to get this PR merged?

@ecurrencyhodler
Copy link

Bump

@halseth
Copy link
Contributor

halseth commented Dec 11, 2018

Related: #1865

@halseth halseth requested a review from cfromknecht December 11, 2018 08:52
cfromknecht
cfromknecht previously approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@cfromknecht
Copy link
Contributor

needs a rebase on master first tho

@dannypaz dannypaz force-pushed the sparkswap/litecoin-regtest branch from c1958a8 to 608a880 Compare January 11, 2019 17:50
@dannypaz
Copy link
Contributor Author

@cfromknecht thanks for the review. We are rebased

@dannypaz dannypaz force-pushed the sparkswap/litecoin-regtest branch from 9d36d60 to 70aff1e Compare January 17, 2019 00:22
@dannypaz
Copy link
Contributor Author

@cfromknecht please re-review before merge

cfromknecht
cfromknecht previously approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊

@jlamur
Copy link
Contributor

jlamur commented Feb 6, 2019 •
edited
Loading

The LTCD repo was destroyed and recreated for whatever reason… In consequence, the commit history wasn't preserved, and my PR ensuring ltcd / litecoind regtest compatibility was probably trashed (I don't have the time to check). (edit: this one: ltcsuite/ltcd#10)

BTW, the diff of go.sum seems weird (lot of deleted lines not related to this PR), please double check that.

@dannypaz you should also fix your author / commiter emails in your commit.

@dannypaz
Copy link
Contributor Author

dannypaz commented Feb 6, 2019 •
edited
Loading

@jlamur I got your PR ltcsuite-archive/ltcd#10 (ltcd was pushed to the archive) merged to master before they did the upgrade. Thanks for letting me know about the author/commit github stuff.

@dannypaz dannypaz force-pushed the sparkswap/litecoin-regtest branch from 70aff1e to d6339fc Compare February 6, 2019 17:02
@dannypaz
Copy link
Contributor Author

dannypaz commented Feb 6, 2019

@cfromknecht you'll need to re-review

@jlamur
Copy link
Contributor

jlamur commented Feb 16, 2019 •
edited
Loading

I got your PR ltcsuite-archive/ltcd#10 (ltcd was pushed to the archive) merged to master before they did the upgrade.

Well it got merged on the archived repository only. The brand new one does contain neither my commit nor my changes.

Ignore that, I was wrong, the changes were squashed in the commit ltcsuite/ltcd@5f2d96fe3.

jlamur
jlamur approved these changes Feb 17, 2019
View reviewed changes
Copy link
Contributor

@jlamur jlamur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

halseth
halseth approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@halseth halseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 👍

@jlamur jlamur mentioned this pull request Feb 21, 2019
Closed
@cfromknecht cfromknecht added this to the 0.6.1 milestone Apr 12, 2019
cfromknecht
cfromknecht reviewed Apr 18, 2019
View reviewed changes
Copy link
Contributor

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@cfromknecht
Copy link
Contributor

@dannypaz needs rebase now that #1865 is in

@cfromknecht
Copy link
Contributor

@dannypaz if you're busy atm we can push this off to 0.7

@dannypaz dannypaz force-pushed the sparkswap/litecoin-regtest branch from ef6690d to 5079335 Compare April 27, 2019 04:13
add litecoin regtest configuration to lnd
6fd5ef8 
regtest change to chainregistry for default port number

merge w/ master
@dannypaz dannypaz force-pushed the sparkswap/litecoin-regtest branch from 5079335 to 6fd5ef8 Compare April 27, 2019 04:14
@dannypaz
Copy link
Contributor Author

@cfromknecht sorry about that. thanks for letting me know. we are rebased

@cfromknecht
Copy link
Contributor

@dannypaz no worries just thought I’d leave a reminder :)

@cfromknecht cfromknecht merged commit 517cdd6 into lightningnetwork:master Apr 29, 2019
@cfromknecht cfromknecht mentioned this pull request May 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlamur jlamur jlamur approved these changes

@halseth halseth halseth approved these changes

@cfromknecht cfromknecht cfromknecht approved these changes

Assignees
No one assigned
Labels
enhancement Improvements to existing features / behaviour needs review PR needs review by regular contributors needs testing PR hasn't yet been actively tested on testnet/mainnet testing Improvements/modifications to the test suite
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.
6 participants
@dannypaz @ecurrencyhodler @halseth @cfromknecht @jlamur @Roasbeef