config: Experimental support for Litecoin/simnet #1865

offerm · 2018-09-07T06:02:23Z

This PR adds the configuration needed to run LND with Litecoin on simnet. The change is minimal and has no impact for users that don't enable this mode. When using this configuration, the user is being warned that this mode is not officially supported.

Fixes #1830.

halseth

utACK, should be safe to add.

halseth · 2018-09-08T07:52:59Z

lnd.go

@@ -134,6 +134,10 @@ func lndMain() error {
 		strings.Title(registeredChains.PrimaryChain().String()),
 		network,
 	)
+	if cfg.Litecoin.SimNet {


Not needed, no risk running on simnet anyway.

I added that here just to inform the user that he can't expect community and LND's team help if encountered problems related to Litecoin and SimNet.

Should I take it out?

Let me know @halseth please.

I would say take it out.

This PR adds the configuration needed to run LND with Litecoin on simnet. The change is minimal and has no impact for users that don't enable this mode. When using this configuration, the user is being warned that this mode is not officially supported.

offerm · 2018-09-14T06:08:51Z

@halseth took out per your suggestion.

Anything else?

cfromknecht · 2018-09-17T07:15:48Z

The simnet params for ltcd should be updated as well: https://github.com/ltcsuite/ltcd/blob/master/chaincfg/params.go#L492

Currently they are just copied from bitcoin simnet. Some things that would need to change:

SubsidyReductionInterval,TargetTimespan, TargetTimePerBlock, MinDiffReductionTime should be made equal to the mainnet values
MinDiffReductionTime should be set to the testnet value
HDCoinType should be 1

offerm · 2018-09-17T21:41:56Z

The simnet params for ltcd should be updated as well: https://github.com/ltcsuite/ltcd/blob/master/chaincfg/params.go#L492

Currently they are just copied from bitcoin simnet. Some things that would need to change:

SubsidyReductionInterval,TargetTimespan, TargetTimePerBlock, MinDiffReductionTime should be made equal to the mainnet values

MinDiffReductionTime should be set to the testnet value

HDCoinType should be 1

@cfromknecht do you suggest to open a PR against ltcsuite/ltcd and wait for a change? or maybe fix these values on LND side once SimNetParams for litecoin selected?

Also, since this is a private network why these parameters are so important?
Any idea why these did change on ltcsuite/ltcd ?

please guide me.

cfromknecht · 2018-09-17T23:58:47Z

@offerm I would definitely welcome a PR to ltcd making those param changes, this is the primary reason ltc simnet was never exposed in lnd.

or maybe fix these values on LND side once SimNetParams for litecoin selected?

I'd prefer not to hack this in, the changes to ltcd are pretty minimal and worth doing properly IMO. FWIW, the ltcd backend would then have different parameters from LND.

Roasbeef · 2018-09-18T00:12:12Z

FWIW, you're aware that litecoind supports regtest right?

dannypaz · 2018-10-02T02:23:05Z

@Roasbeef litecoind regtest is supported, but LND does not

lnd/config.go

Line 549 in e6925cc

str := "%s: regnet mode for litecoin not currently supported"

. It looks like the same changes would have to be made for regtest as well

offerm · 2018-10-08T14:15:27Z

@Roasbeef @cfromknecht LTCD is supporting simnet already (even if using wrong parameters).
The only thing which is missing is this small configuration to LND.

@cfromknecht two questions related to these parameters which should change on LTCD:
a. can you please let me know how do you know that these parameters should change and what their value should be? I would like to get educated before opening such PR.
b. Why to mix the current PR to LND with an unrelated one for LTCD?

The simnet params for ltcd should be updated as well: https://github.com/ltcsuite/ltcd/blob/master/chaincfg/params.go#L492
Currently they are just copied from bitcoin simnet. Some things that would need to change:

SubsidyReductionInterval,TargetTimespan, TargetTimePerBlock, MinDiffReductionTime should be made equal to the mainnet values

MinDiffReductionTime should be set to the testnet value

HDCoinType should be 1

@cfromknecht do you suggest to open a PR against ltcsuite/ltcd and wait for a change? or maybe fix these values on LND side once SimNetParams for litecoin selected?

Also, since this is a private network why these parameters are so important?
Any idea why these did change on ltcsuite/ltcd ?

please guide me.

dannypaz · 2018-10-08T23:43:17Z

@offerm Hoping that this answer helps you

A) litecoin/bitcoin are very similar in ways, but also have their own protocol level differences (e.g. transaction times or supply). You'll have to look at differences between the two, to know which settings need to be changed. I've found that simply searching for bitcoin chain params or litecoin chain params results provide good information on the what/why/how of some of these settings.

B) Its probably meant as a quality issue. You will want the LTCD changes merged before making the change to LND or we wont be running a 'correct' simnet.

offerm · 2018-10-14T14:36:14Z

@cfromknecht @halseth per your request I created
ltcsuite/ltcd#12

cfromknecht

LGTM 🌈

This was referenced Sep 7, 2018

Enable SIMNET ExchangeUnion/xud#433

Closed

[Feature request] LND support for Litecoin on Simnet #1830

Closed

halseth added the needs testing PR hasn't yet been actively tested on testnet/mainnet label Sep 8, 2018

halseth previously approved these changes Sep 8, 2018

View reviewed changes

halseth reviewed Sep 8, 2018

View reviewed changes

halseth added the first pass review done PR has had first pass of review, needs more tho label Sep 8, 2018

offerm dismissed halseth’s stale review via 28213b7 September 14, 2018 06:03

offerm force-pushed the litecoin-simnet branch from fd26974 to 28213b7 Compare September 14, 2018 06:03

halseth approved these changes Sep 17, 2018

View reviewed changes

offerm mentioned this pull request Dec 6, 2018

chaincfg: simnet config to use testnet values. coinType changed to 1 ltcsuite-archive/ltcd#12

Open

halseth mentioned this pull request Dec 11, 2018

add litecoin regtest to lnd #2189

Merged

cfromknecht added this to the 0.6.1 milestone Apr 12, 2019

cfromknecht approved these changes Apr 18, 2019

View reviewed changes

cfromknecht merged commit ab4a675 into lightningnetwork:master Apr 19, 2019

Roasbeef mentioned this pull request Jul 2, 2019

Added simnet support for litecoind #2188

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

config: Experimental support for Litecoin/simnet #1865

config: Experimental support for Litecoin/simnet #1865

offerm commented Sep 7, 2018 •

edited by halseth

Loading

halseth left a comment

halseth Sep 8, 2018

offerm Sep 8, 2018

halseth Sep 11, 2018

offerm commented Sep 14, 2018

cfromknecht commented Sep 17, 2018

offerm commented Sep 17, 2018

cfromknecht commented Sep 17, 2018

Roasbeef commented Sep 18, 2018

dannypaz commented Oct 2, 2018

offerm commented Oct 8, 2018

dannypaz commented Oct 8, 2018 •

edited

Loading

offerm commented Oct 14, 2018

cfromknecht left a comment

config: Experimental support for Litecoin/simnet #1865

config: Experimental support for Litecoin/simnet #1865

Conversation

offerm commented Sep 7, 2018 • edited by halseth Loading

halseth left a comment

Choose a reason for hiding this comment

halseth Sep 8, 2018

Choose a reason for hiding this comment

offerm Sep 8, 2018

Choose a reason for hiding this comment

halseth Sep 11, 2018

Choose a reason for hiding this comment

offerm commented Sep 14, 2018

cfromknecht commented Sep 17, 2018

offerm commented Sep 17, 2018

cfromknecht commented Sep 17, 2018

Roasbeef commented Sep 18, 2018

dannypaz commented Oct 2, 2018

offerm commented Oct 8, 2018

dannypaz commented Oct 8, 2018 • edited Loading

offerm commented Oct 14, 2018

cfromknecht left a comment

Choose a reason for hiding this comment

offerm commented Sep 7, 2018 •

edited by halseth

Loading

dannypaz commented Oct 8, 2018 •

edited

Loading