Skip to content

Commit

Permalink
Merge pull request #2338 from Roasbeef/pr-template
Browse files Browse the repository at this point in the history
github: add PR contribution checklist
  • Loading branch information
Roasbeef authored Dec 18, 2018
2 parents febe6cd + 3439836 commit 6ddb632
Showing 1 changed file with 19 additions and 0 deletions.
19 changes: 19 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
#### Pull Request Checklist

- [ ] All changes are Go version 1.11 compliant
- [ ] The code being submitted is commented according to the
[Code Documentation and Commenting](#CodeDocumentation) section
- [ ] For new code: Code is accompanied by tests which exercise both
the positive and negative (error paths) conditions (if applicable)
- [ ] For bug fixes: Code is accompanied by new tests which trigger
the bug being fixed to prevent regressions
- [ ] Any new logging statements use an appropriate subsystem and
logging level
- [ ] Code has been formatted with `go fmt`

This comment has been minimized.

Copy link
@ccdle12

ccdle12 Dec 18, 2018

Contributor

@Roasbeef was just wondering the differences between calling go fmt vs make fmt

This comment has been minimized.

Copy link
@Roasbeef

Roasbeef Dec 19, 2018

Author Member

Hmm they're the same ish, should probably remove this, thanks!

- [ ] For code and documentation: lines are wrapped at 80 characters
(the tab character should be counted as 8 characters, not 4, as some IDEs do
per default)
- [ ] Running `make check` does not fail any tests
- [ ] Running `go vet` does not report any issues
- [ ] Running `make lint` does not report any **new** issues that did not
already exist

0 comments on commit 6ddb632

Please sign in to comment.