-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
github: add PR contribution checklist
- Loading branch information
Showing
1 changed file
with
19 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
#### Pull Request Checklist | ||
|
||
- [ ] All changes are Go version 1.11 compliant | ||
- [ ] The code being submitted is commented according to the | ||
[Code Documentation and Commenting](#CodeDocumentation) section | ||
- [ ] For new code: Code is accompanied by tests which exercise both | ||
the positive and negative (error paths) conditions (if applicable) | ||
- [ ] For bug fixes: Code is accompanied by new tests which trigger | ||
the bug being fixed to prevent regressions | ||
- [ ] Any new logging statements use an appropriate subsystem and | ||
logging level | ||
- [ ] Code has been formatted with `go fmt` | ||
- [ ] For code and documentation: lines are wrapped at 80 characters | ||
(the tab character should be counted as 8 characters, not 4, as some IDEs do | ||
per default) | ||
- [ ] Running `make check` does not fail any tests | ||
- [ ] Running `go vet` does not report any issues | ||
- [ ] Running `make lint` does not report any **new** issues that did not | ||
already exist |