Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: run LiT itests & unit tests as part of CI #1112

Merged
merged 1 commit into from
Aug 30, 2024
Merged

github: run LiT itests & unit tests as part of CI #1112

merged 1 commit into from
Aug 30, 2024

Conversation

ellemouton
Copy link
Member

@ellemouton ellemouton commented Aug 28, 2024 •
edited
Loading

@ellemouton ellemouton force-pushed the triggerLiTCI branch 2 times, most recently from 4db7462 to 77dabe7 Compare August 28, 2024 18:03
@coveralls
Copy link

coveralls commented Aug 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10613407087

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 18 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 40.289%
Files with Coverage Reduction New Missed Lines %
tapgarden/planter.go 2 74.87%
tapdb/universe.go 4 80.91%
universe/interface.go 12 50.22%
Totals Coverage Status
Change from base Build 10584177556: -0.01%
Covered Lines: 23972
Relevant Lines: 59500
💛 - Coveralls

@ellemouton ellemouton force-pushed the triggerLiTCI branch 2 times, most recently from 7a9af70 to df3f6f9 Compare August 29, 2024 10:22
@ellemouton ellemouton changed the title github: trigger lit CI for current branch github: run LiT itests & unit tests as part of CI Aug 29, 2024
guggero
guggero approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! LGTM 🎉

GeorgeTsagk
GeorgeTsagk approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! slick

@ellemouton
Copy link
Member Author

(cool - think can merge when ready (i dont have le perms))

@guggero guggero merged commit 72b93f8 into lightninglabs:main Aug 30, 2024
18 checks passed
@ellemouton ellemouton deleted the triggerLiTCI branch August 30, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeTsagk GeorgeTsagk GeorgeTsagk approved these changes

@guggero guggero guggero approved these changes

Assignees

@ellemouton ellemouton

Labels
None yet
Projects
Taproot-Assets Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] Create lighting-terminal PR CI job which persistently updates litd's tapd dependency to main HEAD
4 participants
@ellemouton @coveralls @guggero @GeorgeTsagk