Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Create lighting-terminal PR CI job which persistently updates litd's tapd dependency to main HEAD #827

Closed
dstadulis opened this issue Aug 23, 2024 · 3 comments · Fixed by lightninglabs/taproot-assets#1112
Labels
enhancement New feature or request

Comments

@dstadulis
Copy link

Motivation:

  • When changes to tapd occur, in order to fully conclude the ramifications of the PR, testing must occur in litd CI pipeline.
  • There have been instances of tapd PRs been merged, but testing coverage could have been more comprehensive.
  • By creating these perpetually updating tapd dependency PRs, the cross-daemon CI process will be less fault prone

Implementation ideas:

An update notification method

entr
Github Actions
Time-based cron job

Should Update

the tapd module dependency to

  • origin/main HEAD
  • or be extensible to set a development branch (for future releases where engineers want to refrain from merging into main)
@dstadulis dstadulis added the enhancement New feature or request label Aug 23, 2024
@ellemouton
Copy link
Member

Do you only want things to run on merge to master or do you want things to run when a new PR is opened?

@ellemouton
Copy link
Member

(also - i'd say this is something that needs to happen on the taproot-assets github actions side since there you can subscribe to actions from the tap repo)

@dstadulis
Copy link
Author

Do you only want things to run on merge to master or do you want things to run when a new PR is opened?

ah yeah probably most appropriate for the checks to run during PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants