Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix lint VSC permission error #473

Merged
merged 2 commits into from
Jan 5, 2023
Merged

tools: fix lint VSC permission error #473

merged 2 commits into from
Jan 5, 2023

Conversation

guggero
Copy link
Member

@guggero guggero commented Jan 5, 2023

Fixes the linter failure that appeared out of nowhere in all our projects: https://github.com/lightninglabs/lightning-terminal/actions/runs/3843975095/jobs/6547862365

Copy link
Contributor

@positiveblue positiveblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I did this for pool yesterday. In LND @yyforyongyu was able to fix it without marking the folder "safe" for git, but I wasn't able to replicate it in other projects (even after using the same docker images)

@guggero guggero requested a review from jamaljsr January 5, 2023 09:41
Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

Thanks so much for resolving this. I was on a completely different path investigating usage of the -buildvcs flag. It's still not clear to me what the exact problem was, but happy it's fixed nevertheless.

@jamaljsr jamaljsr merged commit 1a1515c into master Jan 5, 2023
@jamaljsr jamaljsr deleted the linter-fix branch January 5, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants