build: update go to v1.19.4-beta #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
positiveblue
force-pushed
the
update-go-19.4
branch
from
677f33d to
177c668
Compare
guggero
reviewed
Jan 5, 2023
positiveblue
force-pushed
the
update-go-19.4
branch
2 times, most recently
from
7caeedc to
82dd3af
Compare
guggero
approved these changes
Jan 5, 2023
positiveblue
force-pushed
the
update-go-19.4
branch
from
82dd3af to
627c9c4
Compare
ffranr
approved these changes
Jan 5, 2023
tools/Dockerfile
Outdated
| @@ -11,6 +11,9 @@ RUN cd /tmp \ | |||
| && mkdir -p /tmp/build/.modcache \ | |||
| && cd /tmp/tools \ | |||
| && go install -trimpath -tags=tools github.com/golangci/golangci-lint/cmd/golangci-lint \ | |||
| && chmod -R 777 /tmp/build/ | |||
| && chmod -R 777 /tmp/build/ \ | |||
| && git config --global --add safe.directory /build | |||
There was a problem hiding this comment.
Is it possible to remove this line now that go has been updated?
There was a problem hiding this comment.
I thought yes, but no, it is not possible.
There was a problem hiding this comment.
Can you try if removing the -buster from the docker image changes anything?
positiveblue
force-pushed
the
update-go-19.4
branch
from
627c9c4 to
2d61471
Compare
Since v1.19.0 `go fmt` also formats comments. This commit is only to ensure that `go fmt ./...` does not modify any of our commited files.
|
Looks like we need to bump the version of |
positiveblue
force-pushed
the
update-go-19.4
branch
from
2d61471 to
53835f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go fmtalso formats commented code so files need to be reformated.P.S: I can extract some of the steps in the actions in a comment one for
Seting up Golang environmentif needed in this PR too