-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support async signing for V2 channel establishment #3411
base: main
Are you sure you want to change the base?
Commits on Nov 20, 2024
-
Expose signing session from InteractivelyFunded
To support async signing, the InteractiveTxSigningSession returned when handling tx_complete needs to be saved in order to retry the funding_tx_constructed method when the signer is unblocked. This unfortunately means an Option as needed since the unfunded V2 channel phase variant is left unfunded until the signer completes.
Configuration menu - View commit details
-
Copy full SHA for 3805e48 - Browse repository at this point
Copy the full SHA 3805e48View commit details -
Support async signing for V2 channel establishment
When handling a tx_complete message, allow signers to return an error indicating that the signer has not yet complete. This will leave the ChannelPhase in an unfunded variant until the signer becomes unblocked.
Configuration menu - View commit details
-
Copy full SHA for 846faf6 - Browse repository at this point
Copy the full SHA 846faf6View commit details -
Remove Result from into_channel methods
These methods always return Ok, so there is no need to use a Result.
Configuration menu - View commit details
-
Copy full SHA for 53fc264 - Browse repository at this point
Copy the full SHA 53fc264View commit details -
Finish handling tx_complete in signer_unblocked
Expand ChannelManager::signer_unblocked to finish handling tx_complete messages. This completes support for async signing in V2 channel establishment.
Configuration menu - View commit details
-
Copy full SHA for 92018f6 - Browse repository at this point
Copy the full SHA 92018f6View commit details
Commits on Nov 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 405f3ad - Browse repository at this point
Copy the full SHA 405f3adView commit details -
Configuration menu - View commit details
-
Copy full SHA for c8bbcff - Browse repository at this point
Copy the full SHA c8bbcffView commit details -
Remove unused errs Vec when claiming payments
The errs Vec in ChannelManager::claim_payment_internal hasn't been populated since commit fea6393. Drop it along with the code that consumed it.
Configuration menu - View commit details
-
Copy full SHA for 770e161 - Browse repository at this point
Copy the full SHA 770e161View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6db89d7 - Browse repository at this point
Copy the full SHA 6db89d7View commit details