Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support async signing for V2 channel establishment #3411

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Commits on Nov 20, 2024

  1. Expose signing session from InteractivelyFunded

    To support async signing, the InteractiveTxSigningSession returned when
    handling tx_complete needs to be saved in order to retry the
    funding_tx_constructed method when the signer is unblocked. This
    unfortunately means an Option as needed since the unfunded V2 channel
    phase variant is left unfunded until the signer completes.
    jkczyz committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    3805e48 View commit details
    Browse the repository at this point in the history
  2. Support async signing for V2 channel establishment

    When handling a tx_complete message, allow signers to return an error
    indicating that the signer has not yet complete. This will leave the
    ChannelPhase in an unfunded variant until the signer becomes unblocked.
    jkczyz committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    846faf6 View commit details
    Browse the repository at this point in the history
  3. Remove Result from into_channel methods

    These methods always return Ok, so there is no need to use a Result.
    jkczyz committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    53fc264 View commit details
    Browse the repository at this point in the history
  4. Finish handling tx_complete in signer_unblocked

    Expand ChannelManager::signer_unblocked to finish handling tx_complete
    messages. This completes support for async signing in V2 channel
    establishment.
    jkczyz committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    92018f6 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Configuration menu
    Copy the full SHA
    405f3ad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c8bbcff View commit details
    Browse the repository at this point in the history
  3. Remove unused errs Vec when claiming payments

    The errs Vec in ChannelManager::claim_payment_internal hasn't been
    populated since commit fea6393. Drop it
    along with the code that consumed it.
    jkczyz committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    770e161 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6db89d7 View commit details
    Browse the repository at this point in the history