Support async signing for V2 channel establishment #3411
Conversation
| @@ -8862,6 +8891,7 @@ pub(super) struct InboundV2Channel<SP: Deref> where SP::Target: SignerProvider { | |||
| pub dual_funding_context: DualFundingChannelContext, | |||
| /// The current interactive transaction construction session under negotiation. | |||
| interactive_tx_constructor: Option<InteractiveTxConstructor>, | |||
| signing_session: Option<InteractiveTxSigningSession>, | |||
There was a problem hiding this comment.
Yeah, honestly I'm not sure how to avoid the Option without introducing a new state variant, which is something we'd prefer to avoid, as discussed.
| // Finish any tx_complete handling waiting on async signing. | ||
| // | ||
| // TODO: Move this into the earlier channel iteration to avoid duplication and the Vec | ||
| // allocation once ChannelPhase is refactored into Channel. This can't be avoided with the | ||
| // current data model because tx_complete handling requires removing the entry from the | ||
| // channel_by_id map and re-inserting it, which can't be done while iterating over the map. |
There was a problem hiding this comment.
This can be done with the ChannelPhase into Channel refactor, right?
There was a problem hiding this comment.
Yup, that's what the comment is referring to.
There was a problem hiding this comment.
Oh i missed a whole line when reading. Stated the exact same thing 🤦♂️
To support async signing, the InteractiveTxSigningSession returned when handling tx_complete needs to be saved in order to retry the funding_tx_constructed method when the signer is unblocked. This unfortunately means an Option as needed since the unfunded V2 channel phase variant is left unfunded until the signer completes.
When handling a tx_complete message, allow signers to return an error indicating that the signer has not yet complete. This will leave the ChannelPhase in an unfunded variant until the signer becomes unblocked.
These methods always return Ok, so there is no need to use a Result.
Expand ChannelManager::signer_unblocked to finish handling tx_complete messages. This completes support for async signing in V2 channel establishment.
jkczyz
force-pushed
the
2024-11-async-signing-v2
branch
from
c3f5063
to
8dfa6d2
Compare
The errs Vec in ChannelManager::claim_payment_internal hasn't been populated since commit fea6393. Drop it along with the code that consumed it.
jkczyz
force-pushed
the
2024-11-async-signing-v2
branch
from
8dfa6d2
to
6db89d7
Compare
|
Fixed a couple |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3411 +/- ##
==========================================
+ Coverage 89.22% 89.23% +0.01%
==========================================
Files 130 130
Lines 106965 106958 -7
Branches 106965 106958 -7
==========================================
+ Hits 95438 95446 +8
+ Misses 8734 8725 -9
+ Partials 2793 2787 -6 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
When handling a
tx_completemessage, allow signers to return an error indicating that the signer has not yet complete. This will leave theChannelPhasein an unfunded variant until the signer becomes unblocked. The user callsChannelManager::signer_unblockedto indicate that signing is complete, which will attempt to finish handling thetx_completemessage again.Based on #3137.
Fixes #3404.