Remove versioning and cleanup warnings #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
force-pushed
the
2024-01-remove-versioning
branch
2 times, most recently
from
1a6699e
to
92b178e
Compare
tnull
force-pushed
the
2024-01-remove-versioning
branch
2 times, most recently
from
d8619a5
to
154dd75
Compare
... as the spec dropped versioning, we now make the corresponding adjustments. While we're at it, we clean up currently unused fields to get rid of the warnings.
... as the spec dropped versioning, we now make the corresponding adjustments.
.. as they are only used in tests.
... which cleans up the remaining warnings.
tnull
force-pushed
the
2024-01-remove-versioning
branch
from
154dd75
to
1416e65
Compare
.. as implementation is not finished and we're hiding it anyways. This will be reverted once we
.. this will keep us from re-introducing any new warnings and force us to handle them.
tnull
force-pushed
the
2024-01-remove-versioning
branch
from
1416e65
to
7712297
Compare
johncantrell97
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39
Closes #62
As the NO VERSIONING proposal was recently merged in the spec, we here drop versioning support from LSPS2 and LSPS1.
While we're at it, we cleanup the remaining warnings emitted by
rustc, and deny warnings for 'stable' builds in CI, which will keep us from re-introducing any new warnings and force us to handle them before merging.