Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSPS1: Disallow compiler warnings once implementation is finished #87

Open
tnull opened this issue Jan 5, 2024 · 0 comments · May be fixed by #140
Open

LSPS1: Disallow compiler warnings once implementation is finished #87

tnull opened this issue Jan 5, 2024 · 0 comments · May be fixed by #140
Labels
LSPS1

Comments

@tnull
Copy link
Collaborator

tnull commented Jan 5, 2024

In #86 we denied warnings in CI generally, but allowed them explicitly for LSPS1 as the implementation is not finished and currently hidden behind a cfg flag anyways.

We should however make sure to disallow warnings again, fix any remaining ones before we drop the cfg flag.
@tnull tnull added the LSPS1 label Jan 5, 2024
@tnull tnull linked a pull request Jul 11, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
LSPS1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

LSPS1: Update message format and get client working tnull/lightning-liquidity
1 participant
@tnull