-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added support to border and radius for canvas2d #425
Merged
wouterlucas
merged 15 commits into
lightning-js:main
from
pecoram:fix/canvas-radius-border
Nov 7, 2024
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c16b31b
fix: added support to border and radius for canvas2d
pecoram f3fa3af
fix: renamed parseBorderColor to parseColorRgba
pecoram c490e9f
fix: inner border
pecoram 02d0dac
fix: border
pecoram f571c2d
Merge branch 'main' into fix/canvas-radius-border
pecoram 7d3b6f3
fix: apply border after texture
pecoram b23fc3a
refactor: removed border context save
pecoram 19800a8
refactor: cleaning up code
pecoram 8e8f9c2
refactor: added border.width check
pecoram ce2be9e
fix: hasQuadShader check once
pecoram 6d92d20
fix: hasQuadShader check once
pecoram 42349ac
Merge remote-tracking branch 'upstream/main' into fix/canvas-radius-b…
pecoram d50bc2a
Merge remote-tracking branch 'upstream/main' into fix/canvas-radius-b…
pecoram f0dd82b
Merge remote-tracking branch 'upstream/main' into fix/canvas-radius-b…
pecoram 4669644
Merge remote-tracking branch 'upstream/main' into fix/canvas-radius-b…
pecoram File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should that be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's decide, having added the missing “shaders” I think it is no longer necessary. In addition, this warning makes the inspector unusable