-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added support to border and radius for canvas2d #425
fix: added support to border and radius for canvas2d #425
Conversation
there is a problem with the position of the border... on the webgl renderer the border is inside (which I think is wrong or at most to be made configurable) while on the canvas renderer it is centered |
Nice, thanks for the contribution! I like how you've isolated it in the Canvas implementation and thanks for the extended review @elsassph! Heads up @jfboeve has been working on a redesign on the shaders/effects portion of the renderer. Stepping away from the Dynamic Shader and having tree shakeable shaders. One of the topics we discussed is shaders and Canvas2D and we're keeping those separate. Limiting Effects to WebGL1/WebGL2 only as it does do not make sense to combine. Trying to come up with something to caters to both WebGL & Canvas2D would only lead to overly complicated effects definition for only a small number of applicable effects for Canvas2D anyway. We'll have to refactor this PR a little bit to make it fit with the new effects/shaders structure down the road. |
if (shType !== ROUNDED_RECTANGLE_SHADER_TYPE) { | ||
console.warn('Unsupported shader:', shType); | ||
} | ||
// if (shType !== ROUNDED_RECTANGLE_SHADER_TYPE) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should that be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's decide, having added the missing “shaders” I think it is no longer necessary. In addition, this warning makes the inspector unusable
No description provided.