Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail if an effectively final method becomes final #254

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Don't fail if an effectively final method becomes final #254

merged 1 commit into from
Oct 26, 2018

Conversation

jsravn
Copy link
Contributor

@jsravn jsravn commented Oct 26, 2018 •
edited by dwijnand
Loading

Fixes #162

dwijnand
dwijnand approved these changes Oct 26, 2018
View reviewed changes
Copy link
Collaborator

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@jsravn jsravn merged commit 4bb0063 into lightbend-labs:master Oct 26, 2018
@jsravn jsravn deleted the effective-final branch October 26, 2018 14:59
@dwijnand dwijnand mentioned this pull request Oct 26, 2018
Closed
@dwijnand dwijnand added this to the 0.4.0 milestone Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

Treat effectively final members as final
2 participants
@jsravn @dwijnand