Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat effectively final members as final #162

Closed
szeiger opened this issue Jan 20, 2017 · 1 comment · Fixed by #254
Closed

Treat effectively final members as final #162

szeiger opened this issue Jan 20, 2017 · 1 comment · Fixed by #254
Labels
enhancement

Comments

@szeiger
Copy link
Contributor

szeiger commented Jan 20, 2017

MiMa currently reports a binary incompatibility when a method is changed from non-final to final even when it is defined in a final class (see scala/scala#5652 (comment) for examples). All members of final classes should be treated as final to avoid these false positives.
@jsravn jsravn mentioned this issue Oct 26, 2018
Merged
@dwijnand
Copy link
Collaborator

Fixed in #254.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't fail if an effectively final method becomes final jsravn/migration-manager
3 participants
@szeiger @SethTisue @dwijnand