Cleaned up commit history for pr#1548 #1648
Conversation
|
If everyone's happy with this, I'm happy with it! 👍 |
bryceosterhaus
force-pushed
the
generator+badge
branch
from
a46cc4f to
eead3fa
Compare
| "jsx": true | ||
| } | ||
| }, | ||
| "extends": "liferay", |
There was a problem hiding this comment.
If you update to the latest version fo the config (v3.0.0) you can drop some of the rules because I rolled them in to the defaults (current "master" defaults here).
For example, I think you could drop the no-for-of-loops and notice plug-ins (eslint-config-liferay includes it and will use the copyright.js file automatically if it exists).
I think you can also drop some rules:
max-len,eol-last,comma-dangle,no-mixed-spaces-and-tabs, and (I think)quotes: all handled by the prettier preset, which is bundled with the liferay preset.no-console,no-undef: already in eslint:recommended, which the preset extends.default-case,no-return-assign,object-shorthand,prefer-const,quote-props: already in the preset, because I added them there.no-unused-vars: already in the preset, albeit with some different options; I'd suggest trying to see if dropping it is viable.
Basically, I think most of the plug-ins and rules can go away, except the React-related ones, and the sorting ones (which ended up being too invasive to bake into the preset).
If you're curious about which rules I added to the preset, I wrote it all up in liferay/eslint-config-liferay#25 — one of the things I did was look at this PR and the existing config on the "develop" branch to see what could be merged "upstream" into the preset.
|
@wincent updated. I left in the |
Good call. And I think we might want to make a React-variant of the config for precisely this kind of thing plus the other React stuff. I think in theory it is possible to create a |
No description provided.