Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Extend "liferay/react" variant in Clay #36

Closed
3 tasks done
wincent opened this issue Mar 13, 2019 · 3 comments
Closed
3 tasks done

Extend "liferay/react" variant in Clay #36

wincent opened this issue Mar 13, 2019 · 3 comments
Labels

Comments

@wincent
Copy link
Contributor

wincent commented Mar 13, 2019

As described in my comment on liferay/clay#1648 we should be able to create a "react.js" file that allows you to extend "eslint-config-liferay/react" instead of "eslint-config-liferay" in projects like Clay. I believe this is possible because I've seen the eslint-config-airbnb project offer multiple entry points.

  • Set up "react" variant (TBD: decide whether to create separate "typescript" variant as well).
  • Use variant in Clay.
  • Remove explicit plug-ins and rules from Clay that got rolled into the variant.
@wincent
Copy link
Contributor Author

wincent commented Mar 13, 2019

Corresponding internal ticket: https://issues.liferay.com/browse/IFI-557

@wincent
Copy link
Contributor Author

wincent commented Jun 20, 2019

Would be "closed" by #42 but we still need to synchronize this with Clay so I am re-titling it to make clear what needs to be done.

@wincent wincent changed the title Create eslint-config-liferay/react variant Extend "liferay/react variant Jun 20, 2019
@wincent wincent changed the title Extend "liferay/react variant Extend "liferay/react" variant in Clay Jun 20, 2019
@wincent
Copy link
Contributor Author

wincent commented Sep 24, 2019

Clay PR is up: liferay/clay#2536

Going to close this one; anybody interested in following along can just subscribe over there.

@wincent wincent closed this as completed Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant