Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-121903 Migrate v2 usages in roles/roles-admin-web #835

Closed
wants to merge 2 commits into from
Closed

LPS-121903 Migrate v2 usages in roles/roles-admin-web #835

wants to merge 2 commits into from

Commits on Mar 3, 2021

  1. LPS-121903 Show the creation button if no creation menu is passed 

    Until now, in order to display the "creation" button (which is the
button with a "+" icon), we have to pass a "creationMenu" object.
In some cases we just want to show the creation button and handle it's
click event listener - so this is what this change does.
    Julien Castelain committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    ce9a4cb View commit details
    Browse the repository at this point in the history

  2. LPS-121903 Migrate v2 usages in roles/roles-admin-web 

    The <clay:management-toolbar-v2 /> tag has been replaced with the
<clay:management-toolbar /> tag (which uses clay v3).

**Test plan**:
- From the global menu, select the **Control Panel** tab
- Navigate to **Roles**
- Make sure you can:
    - Create and delete Regular Roles
    - Create and delete Site Roles
    - Create and delete Organization Roles
    - Create and delete Asset Library Roles
    - Create and delete Account Roles
- Create a Regular Role
- Select (click) the Regular Role you created previously
- Navigate to the **Assignees** tab
- Make sure you can add assignees from this role
- Make sure you can remove assignees from this role
    Julien Castelain committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    5bcc6f1 View commit details
    Browse the repository at this point in the history