Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-121903 Migrate v2 usages in roles/roles-admin-web #835

Closed
wants to merge 2 commits into from
Closed

LPS-121903 Migrate v2 usages in roles/roles-admin-web #835

wants to merge 2 commits into from

Conversation

julien
Copy link

@julien julien commented Feb 24, 2021 •
edited
Loading

The <clay:management-toolbar-v2 /> tag has been replaced with the
<clay:management-toolbar /> tag (which uses clay v3).

Creating and deleting roles should work as expected, as well as adding or
removing assignees from these roles.

Test plan (1):

  • From the global menu, select the Control Panel tab
  • Navigate to Roles
  • Make sure you can:
    • Create and delete Regular Roles
    • Create and delete Site Roles
    • Create and delete Organization Roles
    • Create and delete Asset Library Roles
    • Create and delete Account Roles

Test Plan (2):

  • Create a Regular Role
  • Select (click) the Regular Role you created previously
  • Navigate to the Assignees tab
  • Make sure you can add assignees from this role
  • Make sure you can remove assignees from this role

Additional notes

  • Submitting this as a draft before forwarding to @drewbrokke so that @ambrinchaudhary , @john-co and @markocikos can review

  • This module had an <aui:script> that was defining one of the management toolbar's event handler, and at the same time calling that handler depending on values present in session storage. Since this might be hard to understand, this is what I'm referring to.
    In this change, what I've done is replaced that by using a "propsTransformer" for the management toolbar, another JS module that defines the addAssignees function and a <liferay-frontend:component> to check session storage and conditionally call the addAssignees function.

I think this is OK and I've actually mentioned it to @drewbrokke to make sure, but I'm adding this here so that everyone following this pull request thread knows why this change was made.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:sf - 0 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 8b8f62ff92709b96a4e96c2fd4b0efc97785e77c

Sender Branch:

Branch Name: LPS-121903
Branch GIT ID: 90f89fef729a68c2bf57afa9a358999f794d52e7

0 out of 1jobs PASSED
For more details click here.
     [java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:290)
[stopwatch] [run.batch.test.action: 1:09.830 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:572: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:706: Java returned: 1
      [get] Getting: http://test-1-17/job/test-portal-source-format/4747//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20210224084756345.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20210224084756345.txt
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null422311912.properties

merge-test-results:

[mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results

[junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null385030468

[junitreport] Loading stylesheet jar:file:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl

[junitreport] Transform time: 204ms

[junitreport] Deleting: /tmp/null385030468

[echo] A report with all the test results can be found at test-results/html/index.html.

[mkdir] Created dir: /opt/dev/projects/github/liferay-jenkins-ee/test-results

[copy] Copying 1 file to /opt/dev/projects/github/liferay-jenkins-ee/test-results

[echo] run.batch.test.tear.down.start.timestamp: 02-24-2021 08:48:01:249 PST

[stopwatch] [run.batch.test.tear.down: 0.000 sec]

[echo]

[echo] Ant GC log:

[echo]

[echo] Java HotSpot(TM) 64-Bit Server VM (25.121-b13) for linux-amd64 JRE (1.8.0_121-b13), built on Dec 12 2016 16:36:53 by "java_re" with gcc 4.3.0 20080428 (Red Hat 4.3.0-8)

[echo] Memory: 4k page, physical 32902020k(5202252k free), swap 0k(0k free)

@julien
Copy link
Author

julien commented Feb 24, 2021

Oops

@julien
Copy link
Author

julien commented Feb 24, 2021

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 8b8f62ff92709b96a4e96c2fd4b0efc97785e77c

Sender Branch:

Branch Name: LPS-121903
Branch GIT ID: 3f4739d3177df9a0e28a949ff1312d7c88459374

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-source-format#5041
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#835
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - julien > liferay-frontend - PR#835 - 2021-02-24[08:51:16]
Spira Jenkins Build:publish-spira-report#16472

@julien
Copy link
Author

julien commented Feb 24, 2021

ci:test:relevant

@julien julien changed the title [Don't forward] Migrate v2 usages in roles/roles-admin-web [Don't review yet] Migrate v2 usages in roles/roles-admin-web Feb 24, 2021
@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-source-format#4747
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#835
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - julien > liferay-frontend - PR#835 - 2021-02-24[08:45:26]
Spira Jenkins Build:publish-spira-report#13574

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 0 out of 1 jobs passed in 2 hours 47 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 8b8f62ff92709b96a4e96c2fd4b0efc97785e77c

Upstream Comparison:

Branch GIT ID: bf41ac8d3aa2dbf64656fa7c0635882079d28f09
Jenkins Build URL: Acceptance Upstream DXP (master) #1575

ci:test:relevant - 0 out of 1 jobs PASSED
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    0 Jobs Passed.
    1 Job Failed.

    The sender branch SHA could not be found on julien/LPS-121903. The sender branch may have been force pushed or deleted after the pull request test was initiated.

    fatal: Not a valid branch point: '90f89fef729a68c2bf57afa9a358999f794d52e7'.

For upstream results, click here.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:bundle - 1 out of 1 jobs passed in 46 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4ef1e49a5565418b5bf991238ee548fb8a8965e2

ci:test:bundle - 1 out of 1 jobs PASSED
For more details click here.
Test bundle downloads:

@calvinctvo
Copy link

Hi @julien , the failure doesn't seem to be related to the PR. I've retrigger ci:test:stable and it hasn't finish running.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 10 out of 10 jobs passed in 4 hours 12 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4ef1e49a5565418b5bf991238ee548fb8a8965e2

Upstream Comparison:

Branch GIT ID: 4ef1e49a5565418b5bf991238ee548fb8a8965e2
Jenkins Build URL: Acceptance Upstream DXP (master) #1603

ci:test:stable - 10 out of 10 jobs PASSED
10 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#8482
Jenkins Report:jenkins-report.html
Jenkins Suite: stable
Pull Request:liferay-frontend#835
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:stable
Spira Release Build:master - julien > liferay-frontend - PR#835 - 2021-03-03[12:43:18]
Spira Jenkins Build:publish-spira-report#20957

@julien
Copy link
Author

julien commented Mar 4, 2021

@calvinctvo thanks for the help 👍

@drewbrokke if you have time could you please let me know if we can forward this one?
Thanks

@jbalsas
Copy link

jbalsas commented Mar 5, 2021

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 23 out of 24 jobs passed in 3 hours 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 7deedb562a6145be11b327fc35f9693b6b4e1541

Upstream Comparison:

Branch GIT ID: 7deedb562a6145be11b327fc35f9693b6b4e1541
Jenkins Build URL: Acceptance Upstream DXP (master) #1608

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 22 out of 24 jobs PASSED
22 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 7deedb5:

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

@liferay-continuous-integration liferay-continuous-integration mentioned this pull request Mar 5, 2021
Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#99554

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#7852
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#835
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - julien > liferay-frontend - PR#835 - 2021-03-05[01:40:37]
Spira Jenkins Build:publish-spira-report#17062

@julien julien deleted the LPS-121903 branch March 16, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbrokke drewbrokke drewbrokke left review comments

@markocikos markocikos markocikos left review comments

@jbalsas jbalsas jbalsas left review comments

@kresimir-coko kresimir-coko kresimir-coko approved these changes

Assignees
No one assigned
Labels
ci:test:bundle - success ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@julien @liferay-continuous-integration @wincent @john-co @jbalsas @calvinctvo @markocikos @drewbrokke @kresimir-coko