~Fix move confirmation set to 0 when changing other pref - Fixes #13244 #13250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this just undoes the fix to that issue and will restore a previous bug. Please use git blame to see why things are how they are |
|
Was fixed via e7f091d instead. My commit didn't reintroduce the bug, as I tested before and after, nor was an "undo" (if you compare both commits, one doesn't simply undo the other). Your previous commit added a reference to "data-name" attribute which was missing. I didn't know that I had to add "data-name" instead of simply re-adding "name". |
|
the name attribute was causing a bug, as the hidden field has the same attribute. That's why I changed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.